Skip to content

Conversation

@taslimmuhammed
Copy link
Contributor

Fixes #333
I just changed the disputes, the other files which utilizes this service is not migrated, so there is error, could you check the code please, on your approval, I'll change the remaining too

@gusinacio
Copy link
Contributor

gusinacio commented Oct 10, 2024

Hello, could you rebase your branch?

git pull origin main --rebase

@gusinacio
Copy link
Contributor

gusinacio commented Oct 10, 2024

This is exactly what I was planning to do! Using watch::Receiver<T> over Eventual<t>.

Great work, you can keep going for the remaining.

@carlosvdr
Copy link
Contributor

I do recommend also using interact rebasing to be able to rename the commits ( since we started using release please, try using conventional commits ) also squashing if there's too much going on
:)

@taslimmuhammed taslimmuhammed closed this by deleting the head repository Oct 11, 2024
@taslimmuhammed
Copy link
Contributor Author

Thanks for the review, I'll start migrating the rest too.

@taslimmuhammed
Copy link
Contributor Author

BTW I don't know if I'm doing it right, but I tried rebase several times, but still it shows forked repo is multiple commits ahead[even after my pr is accepted], as of now I reforked the repo for ease [🥲],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop eventuals in favor of Tokio watch + timers

3 participants