-
Notifications
You must be signed in to change notification settings - Fork 24
migrate diputes from eventuals to tokio::watch #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… from Result<String, String>
|
Hello, could you rebase your branch?
|
|
This is exactly what I was planning to do! Using Great work, you can keep going for the remaining. |
|
I do recommend also using interact rebasing to be able to rename the commits ( since we started using release please, try using conventional commits ) also squashing if there's too much going on |
|
Thanks for the review, I'll start migrating the rest too. |
|
BTW I don't know if I'm doing it right, but I tried rebase several times, but still it shows forked repo is multiple commits ahead[even after my pr is accepted], as of now I reforked the repo for ease [🥲], |
Fixes #333
I just changed the disputes, the other files which utilizes this service is not migrated, so there is error, could you check the code please, on your approval, I'll change the remaining too