Skip to content

feat: Move backoff to to the tracker to remove errors #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 16, 2024
Merged

feat: Move backoff to to the tracker to remove errors #377

merged 11 commits into from
Oct 16, 2024

Conversation

carlosvdr
Copy link
Contributor

@carlosvdr carlosvdr commented Oct 15, 2024 •
edited
Loading

fixes #318

@carlosvdr carlosvdr self-assigned this Oct 15, 2024
@coveralls
Copy link

coveralls commented Oct 15, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11374047932

Details

  • 63 of 72 (87.5%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 70.62%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tap-agent/src/agent/sender_account.rs 5 14 35.71%
Files with Coverage Reduction New Missed Lines %
tap-agent/src/agent/sender_account.rs 3 91.77%
Totals Coverage Status
Change from base Build 11351305070: 0.07%
Covered Lines: 4531
Relevant Lines: 6416
💛 - Coveralls

@carlosvdr carlosvdr requested a review from gusinacio October 16, 2024 18:01
@carlosvdr carlosvdr marked this pull request as ready for review October 16, 2024 18:01
suchapalaver
suchapalaver reviewed Oct 16, 2024
View reviewed changes
suchapalaver
suchapalaver reviewed Oct 16, 2024
View reviewed changes
@suchapalaver
Copy link
Collaborator

@carlosvdr The main thing looks good to me but I'm going to let @gusinacio take a look 👍

gusinacio
gusinacio suggested changes Oct 16, 2024
View reviewed changes
@carlosvdr carlosvdr requested a review from gusinacio October 16, 2024 21:21
gusinacio
gusinacio approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlosvdr carlosvdr merged commit 1bde9b4 into main Oct 16, 2024
10 checks passed
@carlosvdr carlosvdr deleted the carlosvdr/tap-223-backoff-in-tracker-per-allocation branch October 16, 2024 22:10
@github-actions github-actions bot mentioned this pull request Oct 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suchapalaver suchapalaver Awaiting requested review from suchapalaver

1 more reviewer

@gusinacio gusinacio gusinacio approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@carlosvdr carlosvdr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Backoff in Tracker per Allocation

4 participants

@carlosvdr @coveralls @suchapalaver @gusinacio