refactor: use tokio::watch for allocations #393
Conversation
Pull Request Test Coverage Report for Build 11483643250Details
💛 - Coveralls |
gusinacio
left a comment
gusinacio
left a comment
There was a problem hiding this comment.
You are getting really good on this. Just some really small things!
If typos and some unnecessary map_errs is the best I could find, you are crushing it.
common/src/allocations/monitor.rs
Outdated
| sleep(interval.div_f32(2.0)) | ||
| }, | ||
| ) | ||
| .map_err(|e| e.to_string()); |
There was a problem hiding this comment.
You dont need to map to strings here.
common/src/attestations/signers.rs
Outdated
| #[tokio::test] | ||
| async fn test_attestation_signers_update_with_allocations() { | ||
| let (mut allocations_writer, allocations) = Eventual::<HashMap<Address, Allocation>>::new(); | ||
| let (allocations_tx, allcoations_rx) = watch::channel(HashMap::new()); |
|
thanks for the review[✌️], I'll send updates asap. |
|
please have a look, BTW do you know review the code just by looking at changes on github or is there any other way🤓 |
gusinacio
left a comment
gusinacio
left a comment
There was a problem hiding this comment.
LGTM, you are doing incredible!
gusinacio
changed the title
|
Thanks again sir🫡 |
|
BTW I don't know if it's right time to ask, but is there any way i could be part of the team? as an intern or junior or any would be great, I really love working on this project |
Hey, you could check here for jobs within Graph Protocol. I work with Semiotic Labs and while we don't have any position open right now, I suggest you sending your resume here. |
3 participants
Fixes #364
Hi, please have a look when you're free, and as usual tell me if any changes has to be made