fix: limit the max concurrent rav requests #396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gustavo Inacio <[email protected]>
gusinacio
force-pushed
the
gustavo/tap-246-limit-the-amount-of-concurrent-rav-requests
branch
from
635e31f to
c23b128
Compare
Pull Request Test Coverage Report for Build 11487689666Details
💛 - Coveralls |
Signed-off-by: Gustavo Inacio <[email protected]>
gusinacio
changed the title
gusinacio
changed the title
carlosvdr
reviewed
Oct 23, 2024
| total_fee_outside_buffer, | ||
| trigger_value = state.config.tap.rav_request_trigger_value, | ||
| "Total fee greater than the trigger value. Triggering RAV request" | ||
| let has_limit_available = state.adaptive_limiter.has_limit(); |
Contributor
There was a problem hiding this comment.
I do not like much the name has_limit_available, id rather have something like has_available_slots_for_requests or thread or sth like that to make it more clear ?
What do you think
I know its not parallel but maybe it gives the idea better
Signed-off-by: Gustavo Inacio <[email protected]>
gusinacio
deleted the
gustavo/tap-246-limit-the-amount-of-concurrent-rav-requests
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.