Skip to content

Conversation

@gusinacio
Copy link
Contributor

No description provided.

@gusinacio gusinacio force-pushed the gustavo/tap-268-dont-create-eventuals-without-initializing branch from 4489366 to 8c90e52 Compare October 29, 2024 20:55
@coveralls
Copy link

coveralls commented Oct 29, 2024

Pull Request Test Coverage Report for Build 11583429897

Details

  • 83 of 106 (78.3%) changed or added relevant lines in 6 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 74.579%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tap-agent/src/agent.rs 0 3 0.0%
common/src/watcher.rs 46 50 92.0%
common/src/indexer_service/http/indexer_service.rs 0 5 0.0%
common/src/allocations/monitor.rs 0 11 0.0%
Files with Coverage Reduction New Missed Lines %
common/src/allocations/monitor.rs 1 0.0%
common/src/indexer_service/http/indexer_service.rs 3 0.0%
Totals Coverage Status
Change from base Build 11582240500: 0.2%
Covered Lines: 5225
Relevant Lines: 7006

💛 - Coveralls

@gusinacio gusinacio force-pushed the gustavo/tap-268-dont-create-eventuals-without-initializing branch from f274bf9 to 5598055 Compare October 29, 2024 22:25
@gusinacio gusinacio marked this pull request as ready for review October 29, 2024 23:15
@gusinacio gusinacio changed the title fix: create watchers with initial value fix: initialize allocations monitor Oct 29, 2024
@gusinacio gusinacio merged commit f0c7d03 into main Oct 29, 2024
10 checks passed
@gusinacio gusinacio deleted the gustavo/tap-268-dont-create-eventuals-without-initializing branch October 29, 2024 23:18
@github-actions github-actions bot mentioned this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants