Skip to content

feat: enable value check #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2024
Merged

feat: enable value check #430

merged 1 commit into from
Nov 1, 2024

Conversation

@gusinacio
Copy link
Contributor

@gusinacio gusinacio commented Oct 29, 2024

Reverts #429

@gusinacio gusinacio marked this pull request as draft October 29, 2024 23:14
@coveralls
Copy link

coveralls commented Oct 29, 2024

Pull Request Test Coverage Report for Build 11583954297

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 74.352%
Changes Missing Coverage Covered Lines Changed/Added Lines %
common/src/tap.rs 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
common/src/tap/checks/deny_list_check.rs 1 98.21%
Totals Coverage Status
Change from base Build 11583945936: 0.01%
Covered Lines: 5195
Relevant Lines: 6987
💛 - Coveralls

@gusinacio gusinacio marked this pull request as ready for review October 30, 2024 22:24
@gusinacio gusinacio changed the title Revert "fix: disable value check" feat: enable value check Oct 31, 2024
anirudh2
anirudh2 approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@anirudh2 anirudh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple revert of something we've already reviewed!

@gusinacio gusinacio merged commit 466a5a9 into main Nov 1, 2024
10 checks passed
@gusinacio gusinacio deleted the revert-429-disable-value-check branch November 1, 2024 21:43
@github-actions github-actions bot mentioned this pull request Nov 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anirudh2 anirudh2 anirudh2 approved these changes

@suchapalaver suchapalaver Awaiting requested review from suchapalaver

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gusinacio @coveralls @anirudh2