Skip to content

Conversation

@carlosvdr
Copy link
Contributor

No description provided.

@carlosvdr carlosvdr self-assigned this Oct 30, 2024
@carlosvdr carlosvdr requested a review from gusinacio October 30, 2024 23:17
@coveralls
Copy link

coveralls commented Oct 30, 2024

Pull Request Test Coverage Report for Build 11670329072

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 11 of 12 (91.67%) changed or added relevant lines in 2 files are covered.
  • 296 unchanged lines in 15 files lost coverage.
  • Overall coverage increased (+0.1%) to 74.652%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tap-agent/src/agent/sender_account.rs 7 8 87.5%
Files with Coverage Reduction New Missed Lines %
common/src/subgraph_client/monitor.rs 1 98.46%
tap-agent/src/tracker/generic_tracker.rs 1 98.04%
common/src/attestations/dispute_manager.rs 2 95.45%
common/src/tap.rs 3 0.0%
tap-agent/src/tap/context/checks/signature.rs 4 87.1%
common/src/tap/checks/value_check.rs 6 90.95%
common/src/indexer_service/http/request_handler.rs 7 0.0%
common/src/allocations/monitor.rs 8 0.0%
common/src/escrow_accounts.rs 9 88.79%
tap-agent/src/agent.rs 11 0.0%
Totals Coverage Status
Change from base Build 11602628063: 0.1%
Covered Lines: 5360
Relevant Lines: 7180

💛 - Coveralls

@carlosvdr carlosvdr marked this pull request as ready for review October 30, 2024 23:43
Comment on lines 296 to 300
let rav_value = rav.map_or(0, |rav| rav.message.valueAggregate);
let rav_value = signed_rav
.expect("Should have a signed rav")
.message
.valueAggregate;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we change that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no reason will revert

@carlosvdr carlosvdr requested a review from gusinacio November 4, 2024 18:24
Copy link
Contributor

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work thank you!

@gusinacio gusinacio merged commit 3ae39c0 into main Nov 4, 2024
10 checks passed
@gusinacio gusinacio deleted the TAP-266 branch November 4, 2024 18:46
@github-actions github-actions bot mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants