Skip to content

refactor: use tokio::watch for allocation id check #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 1, 2024
Merged

refactor: use tokio::watch for allocation id check #443

merged 2 commits into from
Nov 1, 2024

Conversation

@shiyasmohd
Copy link
Contributor

@shiyasmohd shiyasmohd commented Oct 31, 2024

Fixes #441

@coveralls
Copy link

coveralls commented Oct 31, 2024

Pull Request Test Coverage Report for Build 11617844048

Details

  • 59 of 61 (96.72%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 74.681%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tap-agent/src/agent/sender_account.rs 15 16 93.75%
tap-agent/src/agent/sender_allocation.rs 24 25 96.0%
Totals Coverage Status
Change from base Build 11602628063: 0.1%
Covered Lines: 5333
Relevant Lines: 7141
💛 - Coveralls

gusinacio
gusinacio approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gusinacio gusinacio changed the title refactor: drop eventuals in favor of tokio watch + timers for allocation id refactor: use tokio::watch for allocation id check Nov 1, 2024
@gusinacio gusinacio merged commit 4d6ee1c into main Nov 1, 2024
10 checks passed
@gusinacio gusinacio deleted the shiyasmohd/drop-eventuals-and-use-tokio-watch-in-allocation-id branch November 1, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gusinacio gusinacio gusinacio approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Drop eventuals in favor of Tokio watch + timers for allocation id

4 participants

@shiyasmohd @coveralls @gusinacio