Skip to content

fix: change buffered to buffered_unordened for faster collecting #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2024
Merged

fix: change buffered to buffered_unordened for faster collecting #457

merged 1 commit into from
Nov 4, 2024

Conversation

@carlosvdr
Copy link
Contributor

@carlosvdr carlosvdr commented Nov 4, 2024

No description provided.

@carlosvdr carlosvdr self-assigned this Nov 4, 2024
@coveralls
Copy link

coveralls commented Nov 4, 2024

Pull Request Test Coverage Report for Build 11670486445

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 74.61%
Files with Coverage Reduction New Missed Lines %
common/src/watcher.rs 4 92.0%
Totals Coverage Status
Change from base Build 11669110537: -0.04%
Covered Lines: 5360
Relevant Lines: 7184
💛 - Coveralls

@carlosvdr carlosvdr marked this pull request as ready for review November 4, 2024 18:46
@carlosvdr carlosvdr requested a review from gusinacio November 4, 2024 18:46
gusinacio
gusinacio approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gusinacio gusinacio merged commit 7bf77c5 into main Nov 4, 2024
10 checks passed
@gusinacio gusinacio deleted the carlosvdr/TAP-278 branch November 4, 2024 18:49
@github-actions github-actions bot mentioned this pull request Nov 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gusinacio gusinacio gusinacio approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@carlosvdr carlosvdr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@carlosvdr @coveralls @gusinacio