Skip to content

Conversation

@taslimmuhammed
Copy link
Contributor

Fixes #456

  • Please have a look when you're, hope I covered all, if any changes required tell me.

@coveralls
Copy link

coveralls commented Nov 5, 2024

Pull Request Test Coverage Report for Build 11751976614

Details

  • 53 of 54 (98.15%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 72.891%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tap-agent/src/agent/sender_account.rs 18 19 94.74%
Totals Coverage Status
Change from base Build 11749687843: 0.3%
Covered Lines: 5738
Relevant Lines: 7872

💛 - Coveralls

Copy link
Contributor

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in the right direction, just suggesting a few things to simplify the usage.

@taslimmuhammed
Copy link
Contributor Author

Hi, I think it's ready now, have used Ref as parameter for the function.

Copy link
Contributor

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like from the 4 uses of it, 3 don't need it to be async.

I still think that we should keep it as a future tho. If you have a better solution to tackle this go for it.

Else it looks good to me, just some questions and suggestions of improvement (if the compiler lets you do them).

@taslimmuhammed
Copy link
Contributor Author

taslimmuhammed commented Nov 7, 2024

Really sorry to ask but I'd really appreciate your help with some of these.

Copy link
Contributor

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last review

@taslimmuhammed
Copy link
Contributor Author

hi, changed all of them, if any changes required please tell me.

Copy link
Contributor

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gusinacio gusinacio merged commit aba5ac7 into graphprotocol:main Nov 11, 2024
7 of 9 checks passed
@taslimmuhammed
Copy link
Contributor Author

Thanks alot for the helps 🥹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create pipe function in watcher.rs and replace usages

3 participants