Skip to content

fix: use request from gateway instead of serde req #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 6, 2024
Merged

fix: use request from gateway instead of serde req #464

merged 2 commits into from
Nov 6, 2024

Conversation

@gusinacio
Copy link
Contributor

@gusinacio gusinacio commented Nov 6, 2024 •
edited
Loading

Fixes #463

@gusinacio gusinacio requested a review from Theodus November 6, 2024 17:12
@gusinacio gusinacio linked an issue Nov 6, 2024 that may be closed by this pull request
Attestation expect the query to be formatted #463
Closed
@gusinacio gusinacio requested a review from carlosvdr November 6, 2024 17:12
@gusinacio gusinacio force-pushed the gustavo/tap-292-attestation-expect-the-query-to-be-formatted branch from dfda7f1 to cbb339f Compare November 6, 2024 17:16
@coveralls
Copy link

coveralls commented Nov 6, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11708625017

Details

  • 0 of 7 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 74.617%
Changes Missing Coverage Covered Lines Changed/Added Lines %
service/src/service.rs 0 2 0.0%
common/src/indexer_service/http/request_handler.rs 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
common/src/indexer_service/http/request_handler.rs 1 0.0%
Totals Coverage Status
Change from base Build 11693410651: 0.02%
Covered Lines: 5356
Relevant Lines: 7178
💛 - Coveralls

Theodus
Theodus previously approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@Theodus Theodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gusinacio gusinacio force-pushed the gustavo/tap-292-attestation-expect-the-query-to-be-formatted branch from cbb339f to 54e30c4 Compare November 6, 2024 17:18
@gusinacio gusinacio requested a review from Theodus November 6, 2024 17:18
@gusinacio gusinacio force-pushed the gustavo/tap-292-attestation-expect-the-query-to-be-formatted branch from 54e30c4 to 4b022e8 Compare November 6, 2024 17:19
@gusinacio gusinacio merged commit fdeda9f into main Nov 6, 2024
10 checks passed
@gusinacio gusinacio deleted the gustavo/tap-292-attestation-expect-the-query-to-be-formatted branch November 6, 2024 17:24
@github-actions github-actions bot mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Theodus Theodus Theodus approved these changes

@carlosvdr carlosvdr Awaiting requested review from carlosvdr

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Attestation expect the query to be formatted

4 participants

@gusinacio @coveralls @Theodus