Skip to content

Revert "add dips graphql" #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2024
Merged

Revert "add dips graphql" #472

merged 1 commit into from
Nov 7, 2024

Conversation

@gusinacio
Copy link
Contributor

Reverts #331

@gusinacio gusinacio requested a review from mangas November 7, 2024 19:13
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11729738902

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+1.6%) to 74.604%
Files with Coverage Reduction New Missed Lines %
common/src/tap/checks/deny_list_check.rs 1 98.23%
config/src/config.rs 1 91.19%
common/src/cost_model.rs 2 97.3%
Totals Coverage Status
Change from base Build 11727308940: 1.6%
Covered Lines: 5367
Relevant Lines: 7194
💛 - Coveralls

@gusinacio gusinacio requested a review from LNSD November 7, 2024 19:24
@gusinacio gusinacio merged commit 42511b3 into main Nov 7, 2024
10 checks passed
@gusinacio gusinacio deleted the revert-331-dips-graphql branch November 7, 2024 20:11
mangas added a commit that referenced this pull request Nov 7, 2024
@mangas
Reapply "add dips graphql" (#472)
e272592 
This reverts commit 42511b3.
mangas added a commit that referenced this pull request Nov 7, 2024
@mangas
revert: Reapply "add dips graphql" (#472)
2f12a14 
This reverts commit 42511b3.
mangas added a commit that referenced this pull request Nov 8, 2024
@mangas
revert: Reapply "add dips graphql" (#472)
1e9dbbd 
This reverts commit 42511b3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LNSD LNSD Awaiting requested review from LNSD

1 more reviewer

@mangas mangas mangas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gusinacio @coveralls @mangas