Skip to content

Conversation

@mangas
Copy link
Contributor

@mangas mangas commented Nov 7, 2024

No description provided.

Copy link
Contributor

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice work! Just a few suggestions to organize the CHANGELOG and the project in general.

@mangas mangas force-pushed the fix-dips branch 2 times, most recently from 8b46dca to dba5abb Compare November 8, 2024 09:15
@mangas mangas requested a review from gusinacio November 8, 2024 10:35
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Pull Request Test Coverage Report for Build 11739321561

Details

  • 312 of 593 (52.61%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.6%) to 72.622%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/src/service.rs 0 34 0.0%
service/src/database/dips.rs 8 64 12.5%
dips/src/lib.rs 227 301 75.42%
service/src/routes/dips.rs 68 185 36.76%
Totals Coverage Status
Change from base Build 11736056723: -1.6%
Covered Lines: 5711
Relevant Lines: 7864

💛 - Coveralls

Copy link
Contributor

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, lgtm!

@gusinacio gusinacio merged commit fcf9e33 into main Nov 8, 2024
10 checks passed
@gusinacio gusinacio deleted the fix-dips branch November 8, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants