refactor: use middleware for free auth token #499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gustavo Inacio <[email protected]>
gusinacio
changed the title
Member
|
I'll wait till you fix clippy! |
Signed-off-by: Gustavo Inacio <[email protected]>
Signed-off-by: Gustavo Inacio <[email protected]>
Signed-off-by: Gustavo Inacio <[email protected]>
gusinacio
force-pushed
the
gustavo/tap-304-use-bearer-layer-for-static-services
branch
from
a0c8162 to
e58482a
Compare
Contributor
Pull Request Test Coverage Report for Build 11921361871Details
💛 - Coveralls |
Signed-off-by: Gustavo Inacio <[email protected]>
gusinacio
force-pushed
the
gustavo/tap-304-use-bearer-layer-for-static-services
branch
from
e58482a to
6a29e6e
Compare
Contributor
Author
done |
anirudh2
approved these changes
Nov 19, 2024
Member
anirudh2
left a comment
anirudh2
left a comment
There was a problem hiding this comment.
It's cool to start to see some of the middleware stuff you wanted to incorporate. Since this took you a while to figure out, I'd recommend adding comments to anything you found tricky for other devs going forward.
gusinacio
deleted the
gustavo/tap-304-use-bearer-layer-for-static-services
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.