Skip to content

refactor: remove service impl trait #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 19, 2024
Merged

refactor: remove service impl trait #500

merged 5 commits into from
Nov 19, 2024

Conversation

@gusinacio
Copy link
Contributor

@gusinacio gusinacio commented Nov 19, 2024 •
edited
Loading

No description provided.

@gusinacio gusinacio marked this pull request as ready for review November 19, 2024 21:19
@gusinacio gusinacio changed the title refactor: remove generic from indexer error refactor: remove service impl trait Nov 19, 2024
@gusinacio gusinacio requested a review from anirudh2 November 19, 2024 21:20
@coveralls
Copy link

coveralls commented Nov 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11922724334

Details

  • 0 of 300 (0.0%) changed or added relevant lines in 5 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 72.095%
Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/service/src/routes/status.rs 0 1 0.0%
crates/service/src/routes/cost.rs 0 3 0.0%
crates/service/src/routes/request_handler.rs 0 6 0.0%
crates/service/src/service.rs 0 6 0.0%
crates/service/src/service/indexer_service.rs 0 284 0.0%
Files with Coverage Reduction New Missed Lines %
crates/service/src/service/indexer_service.rs 3 0.0%
crates/service/src/service.rs 3 0.0%
Totals Coverage Status
Change from base Build 11921592137: 0.1%
Covered Lines: 5498
Relevant Lines: 7626
💛 - Coveralls

anirudh2
anirudh2 requested changes Nov 19, 2024
View reviewed changes
Copy link
Member

@anirudh2 anirudh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small changes. Please get rid of the magic numbers!

@gusinacio gusinacio requested a review from anirudh2 November 19, 2024 22:13
anirudh2
anirudh2 approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@anirudh2 anirudh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Gustavo!

@gusinacio gusinacio merged commit 210c8f3 into main Nov 19, 2024
10 checks passed
@gusinacio gusinacio deleted the gustavo/tap-305-remove-service-impl branch November 19, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anirudh2 anirudh2 anirudh2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gusinacio @coveralls @anirudh2