Skip to content

feat: Add DIPS ipfs validation #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 11, 2025
Merged

feat: Add DIPS ipfs validation #614

merged 2 commits into from
Feb 11, 2025

Conversation

@mangas
Copy link
Contributor

@mangas mangas commented Feb 10, 2025 •
edited by gusinacio
Loading

BEGIN_COMMIT_OVERRIDE
refactor: add DIPS ipfs validation
END_COMMIT_OVERRIDE

@mangas mangas force-pushed the filipe/dips-ipfs-checks branch 4 times, most recently from 065670e to 2ec7fe9 Compare February 10, 2025 10:28
@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13238735933

Details

  • 60 of 103 (58.25%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 78.647%
Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/dips/src/server.rs 0 2 0.0%
crates/dips/src/price.rs 11 14 78.57%
crates/service/src/service.rs 0 5 0.0%
crates/dips/src/lib.rs 18 30 60.0%
crates/dips/src/ipfs.rs 31 52 59.62%
Totals Coverage Status
Change from base Build 13238671874: -0.2%
Covered Lines: 7418
Relevant Lines: 9432
💛 - Coveralls

@mangas mangas force-pushed the filipe/dips-ipfs-checks branch 3 times, most recently from 8b1a258 to c12c7e3 Compare February 11, 2025 11:42
@mangas mangas force-pushed the filipe/dips-ipfs-checks branch from c12c7e3 to ef4c587 Compare February 11, 2025 12:01
@mangas mangas marked this pull request as ready for review February 11, 2025 12:03
@mangas mangas requested a review from gusinacio February 11, 2025 12:25
gusinacio
gusinacio approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@gusinacio gusinacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mangas mangas enabled auto-merge (squash) February 11, 2025 14:44
@mangas mangas merged commit 32f30db into main Feb 11, 2025
10 checks passed
@mangas mangas deleted the filipe/dips-ipfs-checks branch February 11, 2025 14:52
@github-actions github-actions bot mentioned this pull request Feb 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gusinacio gusinacio gusinacio approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mangas @gusinacio