Skip to content

perf: speed up startup setup queries #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2025
Merged

perf: speed up startup setup queries #625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e51c904
refactor: scalar_tap_receipts and scalar_tap_ravs queries
rotarur Feb 12, 2025
b11bc28
Merge branch 'main' into rotarur/optimize-rav-queries
gusinacio Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...59bfaafd9a38cf342739cdabf8b7bba073d3.json → ...e81089b7b27af2a1dd22a8c6b8da561b6ec1.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 26 additions & 0 deletions .sqlx/query-67c8c6323c92732bb994593223ccb4f7b9b4a4bda786542c18b404d2287e78a7.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 0 additions & 26 deletions .sqlx/query-8fe28629e2453852a41abd452ed519167d3f358d25aa02f306779270a084f8c3.json
View file
Open in desktop

This file was deleted.

31 changes: 9 additions & 22 deletions crates/tap-agent/src/agent/sender_accounts_manager.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,17 +415,11 @@ impl State {
FROM scalar_tap_receipts
GROUP BY signer_address, allocation_id
)
SELECT DISTINCT
SELECT
signer_address,
(
SELECT ARRAY
(
SELECT DISTINCT allocation_id
FROM grouped
WHERE signer_address = top.signer_address
)
) AS allocation_ids
FROM grouped AS top
ARRAY_AGG(allocation_id) AS allocation_ids
FROM grouped
GROUP BY signer_address
"#
)
.fetch_all(&self.pgpool)
Expand Down Expand Up @@ -461,18 +455,11 @@ impl State {

let nonfinal_ravs_sender_allocations_in_db = sqlx::query!(
r#"
SELECT DISTINCT
SELECT
sender_address,
(
SELECT ARRAY
(
SELECT DISTINCT allocation_id
FROM scalar_tap_ravs
WHERE sender_address = top.sender_address
AND NOT last
)
) AS allocation_id
FROM scalar_tap_ravs AS top
ARRAY_AGG(DISTINCT allocation_id) FILTER (WHERE NOT last) AS allocation_ids
FROM scalar_tap_ravs
GROUP BY sender_address
"#
)
.fetch_all(&self.pgpool)
Expand All @@ -481,7 +468,7 @@ impl State {

for row in nonfinal_ravs_sender_allocations_in_db {
let allocation_ids = row
.allocation_id
.allocation_ids
.expect("all RAVs should have an allocation_id")
.iter()
.map(|allocation_id| {
Expand Down
1 change: 1 addition & 0 deletions justfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,4 @@ psql-down:

migrate:
sqlx migrate run --database-url postgresql://postgres:[email protected]:5432

Loading