Skip to content

Conversation

@gusinacio
Copy link
Contributor

@gusinacio gusinacio commented Feb 12, 2025

Create a trait called DatabaseInteractions.

All calls to databases are delegated to trait like:

  • mark_rav_last
  • calculate_fee_until_last_id
  • delete_receipts_between

store_invalid_receipts is implemented in two functions and we use partition_map to provide the correct Vector for each

@gusinacio gusinacio changed the title refactor: route database queries correctly in sender allocation refactor: use correct db tables in sender allocation Feb 12, 2025
@gusinacio gusinacio force-pushed the gustavo/calculate-aggregate-receipt branch from b12d682 to f9b492e Compare February 12, 2025 21:09
@gusinacio gusinacio marked this pull request as ready for review February 12, 2025 21:12
Copy link
Collaborator

@suchapalaver suchapalaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks real good to me

@coveralls
Copy link

coveralls commented Feb 13, 2025

Pull Request Test Coverage Report for Build 13294926655

Details

  • 251 of 430 (58.37%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-1.0%) to 76.115%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/tap-agent/src/agent/sender_allocation.rs 251 430 58.37%
Files with Coverage Reduction New Missed Lines %
crates/tap-agent/src/agent/sender_allocation.rs 1 75.84%
Totals Coverage Status
Change from base Build 13293962248: -1.0%
Covered Lines: 8225
Relevant Lines: 10806

💛 - Coveralls

@gusinacio gusinacio merged commit 49c804b into main Feb 13, 2025
10 checks passed
@gusinacio gusinacio deleted the gustavo/calculate-aggregate-receipt branch February 13, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants