feat: Escrow based signer validation #635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangas
force-pushed
the
filipe/dips-signer-validation
branch
5 times, most recently
from
359f110 to
06cad5f
Compare
Contributor
Pull Request Test Coverage Report for Build 13378757019Details
💛 - Coveralls |
mangas
force-pushed
the
filipe/dips-signer-validation
branch
from
06cad5f to
4dbbef4
Compare
pcarranzav
reviewed
Feb 17, 2025
crates/service/src/service.rs
Outdated
| Arc::new(IpfsClient::new("https://api.thegraph.com/ipfs/").unwrap()); | ||
|
|
||
| // TODO: Try to re-use the same watcher for both DIPS and TAP | ||
| let watcher = escrow_accounts_v2( |
Member
There was a problem hiding this comment.
worth checking with the Semiotic team but I'm 99% sure we need escrow_accounts_v1, as v2 is the one for after we launch Horizon
mangas
force-pushed
the
filipe/dips-signer-validation
branch
from
4dbbef4 to
06a0d63
Compare
pcarranzav
previously approved these changes
Feb 17, 2025
suchapalaver
previously approved these changes
Feb 17, 2025
anirudh2
previously approved these changes
Feb 17, 2025
Member
anirudh2
left a comment
anirudh2
left a comment
There was a problem hiding this comment.
Looks great! I'm approving but you mind creating an issue for this TODO so that we don't lose track of it.
// TODO: Try to re-use the same watcher for both DIPS and TAP
mangas
dismissed stale reviews from anirudh2, suchapalaver, and pcarranzav
via
a1ca33d
mangas
force-pushed
the
filipe/dips-signer-validation
branch
from
06a0d63 to
a1ca33d
Compare
Contributor
Author
Added a ticket to the board |
pcarranzav
approved these changes
Feb 17, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.