fix: skip processing of receipts when there's no receipt for a version #653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TypeLevelConsoli
force-pushed
the
fix-access-to-v2
branch
from
f2fd0bf to
1232a33
Compare
Pull Request Test Coverage Report for Build 13861278667Details
💛 - Coveralls |
neithanmo
reviewed
Mar 13, 2025
Contributor
|
This is amazing, and a great wait to test migrations! |
neithanmo
reviewed
Mar 14, 2025
neithanmo
previously approved these changes
Mar 14, 2025
carlosvdr
previously approved these changes
Mar 14, 2025
suchapalaver
previously approved these changes
Mar 14, 2025
Collaborator
suchapalaver
left a comment
suchapalaver
left a comment
There was a problem hiding this comment.
I love the testing strategy here using the Migrator and I think this means we can consider releasing again now 🚀
TypeLevelConsoli
dismissed stale reviews from suchapalaver, carlosvdr, and neithanmo
via
7496dd7
TypeLevelConsoli
force-pushed
the
fix-access-to-v2
branch
from
6eba1ea to
7496dd7
Compare
Collaborator
Author
|
I rebased the branch and |
suchapalaver
approved these changes
Mar 14, 2025
neithanmo
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip the processing of receipts of a version, when there's no receipt for that version.
This should fix our release issue, as we won't try to access horizon tables when processing v1 receipts anymore.