Enhance middleware error reporting and logging without breaking changes #660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add detailed error logging in attestation middleware - Enhance signer middleware with better error reporting - Improve error responses with structured JSON format - Maintain backward compatibility with existing behavior - Add tests for error handling scenarios This change addresses debugging challenges by adding proper tracing while preserving the original middleware behavior.
neithanmo
force-pushed
the
feat/middleware_logging
branch
from
7fee8e5 to
da3fc4f
Compare
Pull Request Test Coverage Report for Build 13979872372Details
💛 - Coveralls |
suchapalaver
previously approved these changes
Mar 20, 2025
Collaborator
There was a problem hiding this comment.
Nice! I take it this came out of the experience of working on testing patterns?
Yes, I am having trouble to get test scripts running and just get :
* Mark bundle as not supporting multiuse
< HTTP/1.1 400 Bad Request
< connection: close
< content-length: 0
< date: Thu, 20 Mar 2025 21:07:00 GMT
which is not that helpful. I am trying to submit a receipt.
I will need to do similar changes in the tap receipt handler as well, but that would be in another PR
TypeLevelConsoli
requested changes
Mar 20, 2025
Collaborator
TypeLevelConsoli
left a comment
TypeLevelConsoli
left a comment
There was a problem hiding this comment.
great, I'm all in for structured errors
Collaborator
Author
Thanks! @TypeLevelConsoli for suggestion, indeed, that way is clearer |
Co-authored-by: consoli <[email protected]>
Co-authored-by: consoli <[email protected]>
neithanmo
force-pushed
the
feat/middleware_logging
branch
from
4b533de to
b7183b2
Compare
TypeLevelConsoli
requested changes
Mar 20, 2025
TypeLevelConsoli
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves error reporting and logging in our middleware components(for attestation) without changing their existing behavior. It addresses issues where errors in middleware functions were neither reported in response bodies(just an error code) nor logged via tracing, making debugging unnecessarily difficult.
Key Changes
ErrorResponsefor better client feedbackFixes #619 - Error results from middleware functions not reported in logs or responses