Skip to content

Conversation

@LNSD
Copy link
Contributor

@LNSD LNSD commented Mar 26, 2025

This pull request includes several changes to the crates/dips project to update dependencies and refactor the IPFS client implementation. The most important changes include modifying the dependency versions in Cargo.toml, updating the import statements in ipfs.rs, and refactoring the IpfsClient struct.

  • crates/dips/Cargo.toml: Removed the ipfs-api-prelude dependency.
  • crates/dips/src/ipfs.rs: Removed unused imports (http::Uri, ipfs_api_prelude::{IpfsApi, TryFromUri}, and tracing). Updated the imports to use ipfs_api_backend_hyper::{IpfsApi, TryFromUri}.
  • crates/dips/src/ipfs.rs: Refactored the IpfsClient::new method to simplify the creation of the IPFS client by directly using ipfs_api_backend_hyper::IpfsClient::from_str(url).

@LNSD LNSD requested review from mangas and pcarranzav March 26, 2025 21:21
@LNSD LNSD self-assigned this Mar 26, 2025
@github-actions
Copy link
Contributor

Pull Request Test Coverage Report for Build 14093711750

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 76.198%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/dips/src/ipfs.rs 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
crates/dips/src/ipfs.rs 1 55.36%
Totals Coverage Status
Change from base Build 14093565657: 0.02%
Covered Lines: 8711
Relevant Lines: 11432

💛 - Coveralls

@LNSD LNSD merged commit 0a11da4 into main Mar 27, 2025
10 checks passed
@LNSD LNSD deleted the lnsd/fix-dips-ipfs-client branch March 27, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants