Skip to content

Conversation

@suchapalaver
Copy link
Collaborator

Fixes #719

Signed off by Joseph Livesey [email protected]

Copy link
Collaborator

@neithanmo neithanmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!!

@suchapalaver suchapalaver enabled auto-merge (squash) May 14, 2025 19:52
@neithanmo
Copy link
Collaborator

I think we should unify images, they are not that different.
However the only inconvenience is that the ones in contrib contains more stuffs that final users might not need

@suchapalaver suchapalaver merged commit 72648ba into main May 14, 2025
10 checks passed
@suchapalaver suchapalaver deleted the suchapalaver/fix-docker-dependencies branch May 14, 2025 19:59
@coveralls
Copy link

Pull Request Test Coverage Report for Build 15029736174

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 73.038%

Totals Coverage Status
Change from base Build 15020909739: 0.04%
Covered Lines: 8812
Relevant Lines: 12065

💛 - Coveralls

@suchapalaver
Copy link
Collaborator Author

suchapalaver commented May 14, 2025

I think we should unify images, they are not that different. However the only inconvenience is that the ones in contrib contains more stuffs that final users might not need

I think first step we should put in place is a test that the images build and I like the idea about unifiying a builder for these images!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Newer images error on missing libsasl2.so.2

4 participants