feat: Enhance Integration Tests with Load Testing for the indexer-service #723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a command-line interface powered by Clap to select and configure integration tests. This allows for more flexible test runs, including the ability to pass specific parameters like 'num_receipts' to different test suites. Additionally, constants used across tests have been centralized into a dedicated module for improved organization and maintainability.
suchapalaver
previously approved these changes
May 16, 2025
Pull Request Test Coverage Report for Build 15074877446Details
💛 - Coveralls |
suchapalaver
approved these changes
May 16, 2025
TypeLevelConsoli
approved these changes
May 19, 2025
| rand.workspace = true | ||
|
|
||
| indexer-receipt = { path = "../crates/indexer-receipt" } | ||
| num_cpus = "1.16.0" |
There was a problem hiding this comment.
We don't need num_cpus anymore, Rust has std::thread::available_parallelism since 1.59
One less dependency :)
Comment on lines
+49
to
+50
| let concurrency = num_cpus::get(); | ||
| receipt_handler_load_test(num_receipts, concurrency).await?; |
There was a problem hiding this comment.
Suggested change
| let concurrency = num_cpus::get(); | |
| receipt_handler_load_test(num_receipts, concurrency).await?; | |
| let parallelism = std::thread::available_parallelism().expect("unable to get available parallelism").get(); | |
| receipt_handler_load_test(num_receipts, parallelism).await?; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades our integration-tests suite with the following key enhancements:
Load testing for the TAP side of the indexer would be added in next iterations