Skip to content

Conversation

suchapalaver
Copy link
Collaborator

@suchapalaver suchapalaver commented Jun 27, 2025

If you update your Rust version with rustup update you'll start getting a lot of warnings, which this takes care of 👍

Signed off by Joseph Livesey [email protected]

@suchapalaver suchapalaver force-pushed the suchapalaver/clippy-fixes-for-rust-1.88 branch from fb44464 to 5b838f8 Compare June 27, 2025 16:01
@suchapalaver suchapalaver marked this pull request as ready for review June 27, 2025 16:01
@suchapalaver suchapalaver enabled auto-merge (squash) June 27, 2025 16:01
Copy link
Contributor

github-actions bot commented Jun 27, 2025

Pull Request Test Coverage Report for Build 15930614649

Details

  • 23 of 75 (30.67%) changed or added relevant lines in 24 files are covered.
  • 54 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.08%) to 72.494%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/dips/src/lib.rs 2 3 66.67%
crates/monitor/src/client/subgraph_client.rs 6 7 85.71%
crates/profiler/src/lib.rs 0 1 0.0%
crates/service/src/metrics.rs 0 1 0.0%
crates/service/src/service.rs 0 1 0.0%
crates/tap-agent/src/tap/context/escrow.rs 0 1 0.0%
crates/dips/src/ipfs.rs 0 2 0.0%
crates/tap-agent/src/metrics.rs 0 2 0.0%
integration-tests/src/load_test.rs 0 4 0.0%
crates/dips/src/server.rs 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
crates/service/src/tap/checks/deny_list_check.rs 4 81.14%
crates/watcher/src/lib.rs 4 92.71%
crates/dips/src/server.rs 10 31.46%
integration-tests/src/load_test.rs 10 0.0%
crates/monitor/src/client/subgraph_client.rs 26 77.4%
Totals Coverage Status
Change from base Build 15835007232: 0.08%
Covered Lines: 8803
Relevant Lines: 12143

💛 - Coveralls

@suchapalaver suchapalaver disabled auto-merge June 27, 2025 16:34
@suchapalaver suchapalaver enabled auto-merge (squash) June 27, 2025 16:34
@suchapalaver suchapalaver disabled auto-merge June 27, 2025 17:18
@suchapalaver suchapalaver force-pushed the suchapalaver/clippy-fixes-for-rust-1.88 branch from 5b838f8 to 95a26c2 Compare June 30, 2025 14:49
@suchapalaver suchapalaver enabled auto-merge (squash) June 30, 2025 15:04
Copy link
Collaborator

@ryan-s-roberts ryan-s-roberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Named rather than positional string interpolation. How civilised

@suchapalaver suchapalaver merged commit d7ce4b8 into main Jun 30, 2025
12 checks passed
@suchapalaver suchapalaver deleted the suchapalaver/clippy-fixes-for-rust-1.88 branch June 30, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants