fix(tap-agent): check horizon is active before checking for escrow #776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suchapalaver
requested review from
TypeLevelConsoli,
neithanmo and
ryan-s-roberts
suchapalaver
force-pushed
the
suchapalaver/fix/fall-back-to-v1-only-when-horizon-not-active
branch
from
7bcacfc to
a2231b1
Compare
Pull Request Test Coverage Report for Build 16326866236Details
💛 - Coveralls |
neithanmo
approved these changes
Jul 16, 2025
suchapalaver
deleted the
suchapalaver/fix/fall-back-to-v1-only-when-horizon-not-active
branch
Merged
ryan-s-roberts
approved these changes
Jul 16, 2025
| false, | ||
| ) | ||
| .await | ||
| .expect("Error creating escrow_accounts_v2 channel") |
There was a problem hiding this comment.
This is a reasonable crash as it's a feature mismatch?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The tap-agent was crashing because it tried to create the escrow_accounts_v2 channel before checking if Horizon (V2) was active. Since V2 is not active, the network subgraph doesn't have the paymentsEscrowAccounts field, causing the GraphQL query to fail.
Thanks @rotarur fr reporting!