Skip to content

Conversation

suchapalaver
Copy link
Collaborator

@suchapalaver suchapalaver commented Jul 22, 2025

Replacing panics with graceful error handling for collection IDs that have database padding, which was the root cause preventing TAP receipt aggregation from working.

@suchapalaver suchapalaver force-pushed the suchapalaver/fix/handle-padded-collection-id-parsing branch from ab02703 to 4674d48 Compare July 22, 2025 17:23
@coveralls
Copy link

coveralls commented Jul 22, 2025

Pull Request Test Coverage Report for Build 16451325335

Details

  • 5 of 21 (23.81%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 74.582%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/tap-agent/src/agent/sender_accounts_manager.rs 5 21 23.81%
Totals Coverage Status
Change from base Build 16443576183: -0.02%
Covered Lines: 11819
Relevant Lines: 15847

💛 - Coveralls

@suchapalaver suchapalaver force-pushed the suchapalaver/fix/handle-padded-collection-id-parsing branch from 4674d48 to 3c6a537 Compare July 22, 2025 17:29
@suchapalaver suchapalaver marked this pull request as ready for review July 22, 2025 17:30
@suchapalaver suchapalaver merged commit fc6d112 into main Jul 22, 2025
12 checks passed
@suchapalaver suchapalaver deleted the suchapalaver/fix/handle-padded-collection-id-parsing branch July 22, 2025 21:18
This was referenced Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants