Skip to content

Conversation

suchapalaver
Copy link
Collaborator

@suchapalaver suchapalaver commented Jul 24, 2025

This reverts commit f686a5a.

I don't understand the issue with release-please and the RELEASE_TOKEN Edge & Node provided but for now working around using the GITHUB_TOKEN and being able to release is more important while we figure a longer term solution out.

For context, using the GITHUB_TOKEN, which is what we'd been doing suddenly changed behavior and stopped being able to trigger actions on a PR created by another Action, i.e. the release workflow in GitHub, we need to jimmy it by commit an empty commit for example and that messes up the CHANGELOG 😭

@suchapalaver suchapalaver marked this pull request as ready for review July 24, 2025 17:55
@suchapalaver suchapalaver requested a review from anirudh2 July 24, 2025 17:56
@suchapalaver suchapalaver enabled auto-merge (squash) July 24, 2025 17:56
@suchapalaver suchapalaver merged commit a628980 into main Jul 24, 2025
16 of 17 checks passed
@suchapalaver suchapalaver deleted the suchapalaver/ci/undo-ci-changes branch July 24, 2025 18:07
@coveralls
Copy link

Pull Request Test Coverage Report for Build 16504211259

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 74.513%

Files with Coverage Reduction New Missed Lines %
crates/tap-agent/src/agent/sender_account.rs 11 85.14%
Totals Coverage Status
Change from base Build 16481592500: -0.07%
Covered Lines: 11808
Relevant Lines: 15847

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants