fix(ci): improve sync-manifest to handle branch protection#96
Merged
MoonBoi9001 merged 1 commit intomainfrom Jan 16, 2026
Merged
fix(ci): improve sync-manifest to handle branch protection#96MoonBoi9001 merged 1 commit intomainfrom
MoonBoi9001 merged 1 commit intomainfrom
Conversation
- Only sync manifest when tag > manifest (forward-only, never downgrade) - Create PR instead of pushing directly to main (respects branch protection) - Check for existing sync PR to avoid duplicates - Skip release-please while sync PR is open to prevent incorrect release PRs - Update daily sync workflow comment and permissions Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
266077e to
5e7ab67
Compare
Member
Author
RembrandtK
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes sync-manifest to work with branch protection rules and prevent incorrect release PRs.
Changes
Flow
Trigger: Push to
mainbranch (via approved PR)Job 1:
sync-manifestCondition: Only runs if
github.actor != 'github-actions[bot]'(prevents infinite loops)Step 1: Checkout - Gets full git history (
fetch-depth: 0) to access all tagsStep 2: Check for manifest drift
v1.2.0→1.2.0).release-please-manifest.json(e.g.,1.1.0)drift=true(manual deploy happened)drift=false(release PR in progress, don't downgrade)drift=false(all good)Step 3: Update manifest if drifted (only if
drift=true).release-please-manifest.jsonwith the tag versionchore/sync-manifest-to-X.Y.ZJob 2:
release-pleaseCondition: Runs after
sync-manifestcompletes (or is skipped for bot commits)Step 1: Check for open sync PRs
skip=trueand emit warningStep 2: Run release-please (only if
skip != 'true')Scenarios