Skip to content

Add missing cancellation tokens to async stream operations #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
extra2 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add missing cancellation tokens to async stream operations #673

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/GraphQL.Client/GraphQLHttpClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ private async Task<GraphQLHttpResponse<TResponse>> SendHttpRequestAsync<TRespons
using var httpRequestMessage = preprocessedRequest.ToHttpRequestMessage(Options, JsonSerializer);
using var httpResponseMessage = await HttpClient.SendAsync(httpRequestMessage, HttpCompletionOption.ResponseHeadersRead, cancellationToken).ConfigureAwait(false);

var contentStream = await httpResponseMessage.Content.ReadAsStreamAsync().ConfigureAwait(false);
var contentStream = await httpResponseMessage.Content.ReadAsStreamAsync(cancellationToken).ConfigureAwait(false);

if (Options.IsValidResponseToDeserialize(httpResponseMessage))
{
Expand All @@ -190,7 +190,7 @@ private async Task<GraphQLHttpResponse<TResponse>> SendHttpRequestAsync<TRespons
if (contentStream != null)
{
using var sr = new StreamReader(contentStream);
content = await sr.ReadToEndAsync().ConfigureAwait(false);
content = await sr.ReadToEndAsync(cancellationToken).ConfigureAwait(false);
}

throw new GraphQLHttpRequestException(httpResponseMessage.StatusCode, httpResponseMessage.Headers, content);
Expand Down