Skip to content

Conversation

egoodwinx
Copy link
Contributor

@egoodwinx egoodwinx commented Apr 1, 2025

Background

Updated the support ticket to include categories as well as optionally allow selection of the project and target.

#6622

Description

Update the TargetSelector and ProjectSelector

  • allow for optional selections (needs to be "unassigned" since empty text is not allowed).
  • update to toggle showing organization and project name

Update the Ticket page to allow for selection of the Target, Project, and Category

Update the mutation for new tickets to support the category, target, and project changes.

network sends the new inputs but I can't test further

image

Copy link
Contributor

coderabbitai bot commented Apr 1, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@egoodwinx egoodwinx marked this pull request as ready for review April 2, 2025 00:10
@jdolle jdolle requested review from kamilkisiela and n1ru4l April 4, 2025 22:08
Copy link
Collaborator

@jdolle jdolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this overall. These are pretty minor details that I'd prefer be slightly different.

Copy link
Contributor

@n1ru4l n1ru4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few comments

@n1ru4l
Copy link
Contributor

n1ru4l commented May 13, 2025

@egoodwinx can you please take care of the eslint and type errors?

You can run the following commands locally:

pnpm typecheck
pnpm lint

Copy link
Contributor

@n1ru4l n1ru4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdolle jdolle requested a review from n1ru4l June 2, 2025 18:40
Comment on lines +124 to +130
{isOptional ? (
<SelectItem key="empty" value="empty" data-cy="project-picker-option-Unassigned">
Unassigned
</SelectItem>
))}
) : (
<></>
)}
Copy link
Contributor

@n1ru4l n1ru4l Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be isOptional && (), to avoid the ternary. TBH I don't care too much about using a ternary here, but rather having the else condition being a Fragment instead of simply null.

This expression can just be shorter.

@n1ru4l
Copy link
Contributor

n1ru4l commented Jun 26, 2025

Since you mentioned that you did not check the network calls, we first need to verify this is working either on staging or our development environment. Neither of those currently have a zendesk setup, so we first need to improve that.

@n1ru4l n1ru4l mentioned this pull request Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants