-
Notifications
You must be signed in to change notification settings - Fork 121
update support ticket to support categories, project, and target options #6689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
packages/services/api/src/modules/support/resolvers/SupportTicket.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this overall. These are pretty minor details that I'd prefer be slightly different.
packages/services/api/src/modules/support/providers/support-manager.ts
Outdated
Show resolved
Hide resolved
packages/services/api/src/modules/support/providers/support-manager.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few comments
@egoodwinx can you please take care of the eslint and type errors? You can run the following commands locally:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #6689 (comment)
{isOptional ? ( | ||
<SelectItem key="empty" value="empty" data-cy="project-picker-option-Unassigned"> | ||
Unassigned | ||
</SelectItem> | ||
))} | ||
) : ( | ||
<></> | ||
)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be isOptional && ()
, to avoid the ternary. TBH I don't care too much about using a ternary here, but rather having the else condition being a Fragment instead of simply null
.
This expression can just be shorter.
Since you mentioned that you did not check the network calls, we first need to verify this is working either on staging or our development environment. Neither of those currently have a zendesk setup, so we first need to improve that. |
Background
Updated the support ticket to include categories as well as optionally allow selection of the project and target.
#6622
Description
Update the TargetSelector and ProjectSelector
Update the Ticket page to allow for selection of the Target, Project, and Category
Update the mutation for new tickets to support the category, target, and project changes.
network sends the new inputs but I can't test further