feat: Advanced breaking change detection for inputs and arguments for router #6906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
jdolle
reviewed
Jul 30, 2025
| } else if let Some(type_def) = schema.type_by_name(&type_name) { | ||
| match type_def { | ||
| TypeDefinition::Scalar(scalar_def) => { | ||
| ctx.schema_coordinates.insert(scalar_def.name.clone()); |
There was a problem hiding this comment.
Curious -- why clone scalar name but not type_name above?
There was a problem hiding this comment.
scalar_def here is a shared reference so it needs to be a copy to insert into schema coordinates, type_name is in a loop so its owned by the loop and can be directly inserted from my understanding
| } | ||
|
|
||
| fn enter_argument( | ||
| fn enter_argument( |
| .insert(format!("{arg_type_name}.{value_str}").to_string()); | ||
| } | ||
| Value::List(_) => { | ||
| // handled by enter_list_value |
| let has_value = match arg_value { | ||
| Value::Null => false, | ||
| Value::Variable(var_name) => { | ||
| ctx.variables_with_defaults.contains(var_name) |
There was a problem hiding this comment.
should you check ctx.non_null_variables here also?
jdolle
reviewed
Aug 7, 2025
| @@ -382,7 +383,7 @@ impl<'a> OperationVisitor<'a, SchemaCoordinatesContext> for SchemaCoordinatesVis | |||
| let has_value = match arg_value { | |||
| Value::Null => false, | |||
| Value::Variable(var_name) => { | |||
| ctx.variables_with_defaults.contains(var_name) | |||
| ctx.variables_with_defaults.contains(var_name) && ctx.non_null_variables.contains(var_name) | |||
There was a problem hiding this comment.
I think this should be an or.
Please add a test specific to this case so we can confirm this is behaving as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Addressing: #6816
Whether an input field is used as nullable or non-nullable must be included within the reported schema coordinates using the ! character.
Description
To accurately determine whether a change is breaking or not based on traffic, we must track whether or not an argument or input's value has actually been provided or not.
Track used variables, if input variables were provided, non null variables, and variables with defaults.
Add unit tests based on #6816
Didn't E2E test - just added unit tests.
Checklist