Skip to content

fix: correctly trim operation name on insights and add popover title #6909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions packages/web/app/src/components/target/insights/List.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { useDebouncedCallback } from 'use-debounce';
import { Scale, Section } from '@/components/common';
import { Button } from '@/components/ui/button';
import { Input } from '@/components/ui/input';
import { Link } from '@/components/ui/link';
import { Tooltip, TooltipContent, TooltipProvider, TooltipTrigger } from '@/components/ui/tooltip';
import { Sortable, Table, TBody, Td, Th, THead, Tr } from '@/components/v2';
import { env } from '@/env/frontend';
Expand All @@ -14,7 +15,6 @@ import { DateRangeInput } from '@/gql/graphql';
import { useDecimal, useFormattedDuration, useFormattedNumber } from '@/lib/hooks';
import { pick } from '@/lib/object';
import { ChevronUpIcon, ExclamationTriangleIcon } from '@radix-ui/react-icons';
import { Link } from '@tanstack/react-router';
import {
createColumnHelper,
flexRender,
Expand Down Expand Up @@ -68,7 +68,7 @@ function OperationRow({
<Tr>
<Td className="font-medium">
<div className="flex items-center gap-2">
<Button variant="orangeLink" className="h-auto p-0" asChild>
<Button variant="orangeLink" className="h-auto p-0" asChild title={operation.name}>
<Link
className="block max-w-[300px] truncate"
to="/$organizationSlug/$projectSlug/$targetSlug/insights/$operationName/$operationHash"
Expand Down Expand Up @@ -234,7 +234,12 @@ function OperationsTable({
const sortedColumnsById = tableInstance.getState().sorting.map(s => s.id);

return (
<div className={clsx('rounded-md border border-gray-800 bg-gray-900/50 p-5', className)}>
<div
className={clsx(
'overflow-x-scroll rounded-md border border-gray-800 bg-gray-900/50 p-5',
className,
)}
>
<Section.Title>Operations</Section.Title>
<Section.Subtitle>List of all operations with their statistics</Section.Subtitle>

Expand Down
12 changes: 6 additions & 6 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading