Skip to content

Pin to the latest compatibility date for Cloudflare workers #2237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Pin to the latest compatibility date for Cloudflare workers #2237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/healthy-hotels-design.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@envelop/response-cache-cloudflare-kv': minor
---

Pin response-cache-cloudflare-kv to the latest compatibility date for Cloudflare worker types
2 changes: 1 addition & 1 deletion packages/plugins/response-cache-cloudflare-kv/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
},
"typings": "dist/typings/index.d.ts",
"peerDependencies": {
"@cloudflare/workers-types": "^4.20231121.0",
"@cloudflare/workers-types": "^4.20240512.0",
"@envelop/response-cache": "^6.1.2",
"graphql": "^14.0.0 || ^15.0.0 || ^16.0.0"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/plugins/response-cache-cloudflare-kv/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { ExecutionResult } from 'graphql';
import type { ExecutionContext, KVNamespace } from '@cloudflare/workers-types';
import type { ExecutionContext, KVNamespace } from '@cloudflare/workers-types/2023-07-01';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this have the potential to age poorly ? We will have to update all imports when we update the types dependency ?

import type { Cache, CacheEntityRecord } from '@envelop/response-cache';
import { buildOperationKey } from './cache-key.js';
import { invalidate } from './invalidate.js';
Expand Down
2 changes: 1 addition & 1 deletion packages/plugins/response-cache-cloudflare-kv/test/index.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { ExecutionResult } from 'graphql';
import type { ExecutionContext, KVNamespace } from '@cloudflare/workers-types';
import type { ExecutionContext, KVNamespace } from '@cloudflare/workers-types/2023-07-01';
import type { Cache } from '@envelop/response-cache';
import { buildOperationKey } from '../src/cache-key.js';
import { createKvCache, type KvCacheConfig } from '../src/index.js';
Expand Down
2 changes: 1 addition & 1 deletion packages/plugins/response-cache-cloudflare-kv/test/invalidate.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { ExecutionResult } from 'graphql';
import type { ExecutionContext, KVNamespace } from '@cloudflare/workers-types';
import type { ExecutionContext, KVNamespace } from '@cloudflare/workers-types/2023-07-01';
import { buildEntityKey, buildOperationKey } from '../src/cache-key.js';
import { KvCacheConfig } from '../src/index.js';
import { getAllKvKeysForPrefix, invalidate } from '../src/invalidate.js';
Expand Down
2 changes: 1 addition & 1 deletion packages/plugins/response-cache-cloudflare-kv/test/set.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { ExecutionResult } from 'graphql';
import type { ExecutionContext, KVNamespace } from '@cloudflare/workers-types';
import type { ExecutionContext, KVNamespace } from '@cloudflare/workers-types/2023-07-01';
import { buildEntityKey, buildOperationKey } from '../src/cache-key.js';
import { KvCacheConfig } from '../src/index.js';
import { getAllKvKeysForPrefix } from '../src/invalidate.js';
Expand Down
24 changes: 12 additions & 12 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.