Fix non-nullable field error in batch execution #1324
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omahili
changed the title
omahili
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm attempting to fix #1288 and as described in the discussion it seemed to be an issue with the mapping in batch execution. However after some debugging I noticed that the executor is failing within a try-catch and returning the error from
completeValueso I'm not sure we can fix this at the batch execution level only.One additional issue I found was within the results in DataLoader, so I had to change
splitResultsto match the number of expected results. This could potentially be removed if we find a way to better map the results before it gets there.I added a couple of tests for both a single and multiple executions. The only way I could simulate an early exit with a null result within the executable schema was to add the type def without the resolver for it.
Let me know if you have any idea on the best way to move forward with this.