Skip to content

fix(executor-http): avoid shared AbortController in Cloudflare Workers #1347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(executor-http): avoid shared AbortController in Cloudflare Workers #1347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/lovely-coins-dream.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@graphql-tools/executor-http': patch
---

Avoid shared AbortController instance on CloudflareWorkers because it gives `Cannot perform I/O on behalf of a different request.` error.
This change ensures that the AbortController is only created when not running in a Cloudflare Workers environment.
14 changes: 10 additions & 4 deletions packages/executors/http/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,11 @@ export function buildHTTPExecutor(
request: ExecutionRequest<any, any, any, HTTPExecutorOptions>,
excludeQuery?: boolean,
) => {
disposeCtrl ||= new AbortController();
if (disposeCtrl.signal.aborted) {
// @ts-expect-error Cloudflare Workers doesn't like the shared AbortController
if (!request.cf) {
disposeCtrl ||= new AbortController();
}
if (disposeCtrl?.signal.aborted) {
return createResultForAbort(disposeCtrl.signal.reason);
}
const fetchFn = request.extensions?.fetch ?? options?.fetch ?? defaultFetch;
Expand Down Expand Up @@ -214,7 +217,10 @@ export function buildHTTPExecutor(
request.extensions = restExtensions;
}

const signals = [disposeCtrl.signal];
const signals = [];
if (disposeCtrl?.signal) {
signals.push(disposeCtrl.signal);
}
const signalFromRequest = request.signal || request.info?.signal;
if (signalFromRequest) {
if (signalFromRequest.aborted) {
Expand All @@ -229,7 +235,7 @@ export function buildHTTPExecutor(
signals.push(subscriptionCtrl.signal);
}

const signal = abortSignalAny(signals);
const signal = signals.length ? abortSignalAny(signals) : undefined;

const upstreamErrorExtensions: UpstreamErrorExtensions = {
request: {
Expand Down
Loading