-
Notifications
You must be signed in to change notification settings - Fork 23
Configure some batch delegation options #1403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚀 Snapshot Release (
|
Package | Version | Info |
---|---|---|
@graphql-mesh/fusion-runtime |
0.12.0-alpha-fd3ab4cc5fa847a51a4bbe579faf80b051369e23 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/gateway |
1.16.4-alpha-fd3ab4cc5fa847a51a4bbe579faf80b051369e23 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/nestjs |
1.0.23-alpha-fd3ab4cc5fa847a51a4bbe579faf80b051369e23 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/plugin-aws-sigv4 |
1.0.19-alpha-fd3ab4cc5fa847a51a4bbe579faf80b051369e23 |
npm ↗︎ unpkg ↗︎ |
@graphql-mesh/plugin-opentelemetry |
1.3.67-alpha-fd3ab4cc5fa847a51a4bbe579faf80b051369e23 |
npm ↗︎ unpkg ↗︎ |
@graphql-mesh/plugin-prometheus |
1.3.55-alpha-fd3ab4cc5fa847a51a4bbe579faf80b051369e23 |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/gateway-runtime |
1.11.0-alpha-fd3ab4cc5fa847a51a4bbe579faf80b051369e23 |
npm ↗︎ unpkg ↗︎ |
🚀 Snapshot Release (Bun Docker Image)The latest changes of this PR are available as image on GitHub Container Registry (based on the declared
|
🚀 Snapshot Release (Node Docker Image)The latest changes of this PR are available as image on GitHub Container Registry (based on the declared
|
This reverts commit b23587a.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR configures batch delegation options for GraphQL DataLoader and renames an experimental configuration option. The changes allow users to configure batch delegation behavior (like maxBatchSize
) while keeping the API minimal, and correct a naming inconsistency in the batch execution configuration.
- Rename
__experimental__batchDelegation
to__experimental__batchExecution
for clarity - Add new
__experimental__batchDelegateOptions
configuration to control batch delegation behavior - Remove unused
memlab
dependency from internal perf package
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
packages/runtime/tests/sync.test.ts | Update test to use renamed batch execution option |
packages/runtime/src/types.ts | Add new batch delegate options type and rename existing option |
packages/runtime/src/createGatewayRuntime.ts | Pass new batch delegate options to unified graph manager |
packages/fusion-runtime/src/unifiedGraphManager.ts | Define BatchDelegateOptions interface and thread through configuration |
packages/fusion-runtime/src/federation/supergraph.ts | Pass batch delegate options to stitched schema creation |
internal/perf/package.json | Remove unused memlab dependency |
.changeset/shaggy-trains-camp.md | Document new batch delegation configuration feature |
.changeset/angry-plants-hide.md | Document batch execution option rename |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Ref GW-451
To change the max batch size from
Infinity
to10
, for example, do this:Note that there are many more batch delegation (GraphQL DataLoader) options to choose from, but we want to keep user changes to a minimum to the internal workings.
Also, remove
memlabs
from an internal package (an overlooked leftover of #1372).