Skip to content

Update Examples #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2025
Merged

Update Examples #674

merged 1 commit into from
Feb 17, 2025

Conversation

theguild-bot
Copy link
Collaborator

The examples converted from E2E tests have changed in 43804ce.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 17, 2025 •
edited
Loading

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Upgraded a core dependency version across multiple demonstration projects for improved stability and maintenance.

Walkthrough

This pull request updates the @apollo/rover dependency version across several federation example projects. The dependency in the package.json files for federation-example, federation-mixed, and federation‑subscriptions‑passthrough has been incremented from ^0.27.0 to ^0.27.1. No other changes have been made.

Changes

File(s) Change Summary
examples/federation-{example,mixed,subscriptions-...}/package.json Updated @apollo/rover dependency version from ^0.27.0 to ^0.27.1

Possibly related PRs

Poem

I'm a rabbit with a happy heart,
Hoping through code with a joyful start,
Dependencies updated with a gentle prance,
My whiskers twitch, join me in the dance,
Carrots crunch as our changes advance! 🥕🐇

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 43804ce and fad22ef.

⛔ Files ignored due to path filters (6)
  • examples/federation-example/example.tar.gz is excluded by !**/*.gz
  • examples/federation-example/package-lock.json is excluded by !**/package-lock.json
  • examples/federation-mixed/example.tar.gz is excluded by !**/*.gz
  • examples/federation-mixed/package-lock.json is excluded by !**/package-lock.json
  • examples/federation-subscriptions-passthrough/example.tar.gz is excluded by !**/*.gz
  • examples/federation-subscriptions-passthrough/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (3)
  • examples/federation-example/package.json (1 hunks)
  • examples/federation-mixed/package.json (1 hunks)
  • examples/federation-subscriptions-passthrough/package.json (1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
`examples/**`: In this directory we keep all the examples. E...

examples/**: In this directory we keep all the examples. Examples are generated using a scheduled CI pipeline.
When changes are made to Gateway config, we expect to see some changes in the examples directory.

  • examples/federation-example/package.json
  • examples/federation-subscriptions-passthrough/package.json
  • examples/federation-mixed/package.json
`**`: For all PRs, we would like to verify that a Linear iss...

**: For all PRs, we would like to verify that a Linear issue is linked. Check if there's a mention for "GW-*" in the PR description, and the us know when it's missing.

In most cases, when a PR adds a new functionality, we would like to make sure it has documentation in the corresponding console project.
Use the global knowledge feature to search for PRs in graphql-hive/console repository that adds documentation. Suggest to create a follow up issue to add the missing documentation.

  • examples/federation-example/package.json
  • examples/federation-subscriptions-passthrough/package.json
  • examples/federation-mixed/package.json
⏰ Context from checks skipped due to timeout of 90000ms (31)
  • GitHub Check: Binary built on ubuntu-24.04-arm
  • GitHub Check: Binary built on windows-latest
  • GitHub Check: Binary built on macos-14
  • GitHub Check: Binary built on macos-13
  • GitHub Check: Bun Docker image
  • GitHub Check: Binary built on ubuntu-latest
  • GitHub Check: Node Docker image
  • GitHub Check: Unit / Bun
  • GitHub Check: Unit / Node v23
  • GitHub Check: E2E / Bun Docker on Ubuntu
  • GitHub Check: E2E / Bun on Ubuntu
  • GitHub Check: E2E / Node Binary on Windows
  • GitHub Check: E2E / Node Binary on Ubuntu
  • GitHub Check: E2E / Node Docker on Ubuntu
  • GitHub Check: E2E / Node 23 on Ubuntu
  • GitHub Check: Leaks / Node v23
  • GitHub Check: E2E / Node 22 on Ubuntu
  • GitHub Check: Benchmark / bun / 1000 items
  • GitHub Check: Leaks / Node v22
  • GitHub Check: Benchmark / bun / 100 items
  • GitHub Check: Leaks / Node v20
  • GitHub Check: Benchmark / bun / 10 items
  • GitHub Check: E2E / Node 20 on Ubuntu
  • GitHub Check: Build
  • GitHub Check: Benchmark / node / 1000 items
  • GitHub Check: E2E / Node 18 on Ubuntu
  • GitHub Check: Benchmark / node / 100 items
  • GitHub Check: Leaks / Node v18
  • GitHub Check: Bundle
  • GitHub Check: Benchmark / node / 10 items
  • GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (3)
examples/federation-example/package.json (1)

6-6: Update Dependency Version for @apollo/rover

The @apollo/rover dependency has been updated to ^0.27.1 to ensure consistency across all example projects. Please verify that this minor bump is compatible with all usages in the examples.

examples/federation-mixed/package.json (1)

16-16: Update Dependency Version for @apollo/rover

The version of @apollo/rover has been updated to ^0.27.1, aligning this project with the other example projects. No further changes appear necessary.

examples/federation-subscriptions-passthrough/package.json (1)

22-22: Update Dependency Version for @apollo/rover

The dependency update to @apollo/rover version ^0.27.1 is consistent with the updates in the other examples. Please verify that the change integrates smoothly with the existing scripts and tooling.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@theguild-bot
Copy link
Collaborator Author

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-hive/gateway 1.10.3-alpha-fad22ef97e8115c695f6e1a68387a95582a40b3f npm ↗︎ unpkg ↗︎

@theguild-bot
Copy link
Collaborator Author

🚀 Snapshot Release (Binary for macOS-ARM64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

@theguild-bot
Copy link
Collaborator Author

🚀 Snapshot Release (Binary for Linux-X64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

@theguild-bot
Copy link
Collaborator Author

🚀 Snapshot Release (Bun Docker Image)

The latest changes of this PR are available as image on GitHub Container Registry (based on the declared changesets):

ghcr.io/graphql-hive/gateway:1.10.3-alpha-fad22ef97e8115c695f6e1a68387a95582a40b3f-bun

@theguild-bot
Copy link
Collaborator Author

🚀 Snapshot Release (Node Docker Image)

The latest changes of this PR are available as image on GitHub Container Registry (based on the declared changesets):

ghcr.io/graphql-hive/gateway:1.10.3-alpha-fad22ef97e8115c695f6e1a68387a95582a40b3f

@theguild-bot
Copy link
Collaborator Author

🚀 Snapshot Release (Binary for Linux-ARM64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

@theguild-bot
Copy link
Collaborator Author

🚀 Snapshot Release (Binary for macOS-X64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

@theguild-bot
Copy link
Collaborator Author

🚀 Snapshot Release (Binary for Windows-X64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

@ardatan ardatan merged commit 8144ace into main Feb 17, 2025
48 checks passed
@ardatan ardatan deleted the examples/update branch February 17, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theguild-bot @ardatan