feat: useApolloInlineTrace plugin for federated tracing (v3)
#1621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9397dec The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ardatan
reviewed
Aug 18, 2022
ardatan
reviewed
Aug 18, 2022
ardatan
reviewed
Aug 18, 2022
|
I agree with changing the name. As you said, it is Apollo specific. |
|
Waiting for graphql-hive/envelop#1490. |
enisdenjo
changed the title
useInlineTrace plugin for federated tracinguseApolloInlineTrace plugin for federated tracing
|
@ardatan due to limitations with After the limitations are lifted, we can deprecate this plugin in favor of envelop. P.S. I renamed the plugin to |
enisdenjo
changed the title
useApolloInlineTrace plugin for federated tracinguseApolloInlineTrace plugin for federated tracing (v3)
ardatan
approved these changes
Aug 19, 2022
This was referenced Sep 21, 2022
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1607
Only one question: since the federated tracing thing is Apollo specific, should the plugin be named
useApolloInlineTraceinstead? Yes, it should (99a9abb).