Default is false

Author: ardatan

docs/README.md

@@ -59,6 +59,7 @@ headers:
             named: x-tenant-id
             rename: x-acct-tenant
 hmac_signature:
+  enabled: false
   extension_name: hmac_signature
 http:
   host: 0.0.0.0
@@ -1351,13 +1352,14 @@ For more information on the available functions and syntax, see the
 
 |Name|Type|Description|Required|
 |----|----|-----------|--------|
-|**enabled**|||yes|
+|**enabled**||Default: `false`<br/>|no|
 |**extension\_name**|`string`|Default: `"hmac_signature"`<br/>|no|
 |**secret**|`string`||yes|
 
 **Example**
 
 ```yaml
+enabled: false
 extension_name: hmac_signature
 
 ```

lib/executor/src/executors/http.rs

@@ -169,6 +169,11 @@ impl HTTPSubgraphExecutor {
         };
 
         let hmac_signature_ext = if should_sign_hmac {
+            if self.config.hmac_signature.secret.is_empty() {
+                return Err(SubgraphExecutorError::HMACSignatureError(
+                    "HMAC signature secret is empty".to_string(),
+                ));
+            }
             let mut mac = HmacSha256::new_from_slice(self.config.hmac_signature.secret.as_bytes())
                 .map_err(|e| {
                     SubgraphExecutorError::HMACSignatureError(format!(

lib/router-config/src/hmac_signature.rs

@@ -16,6 +16,7 @@ pub struct HMACSignatureConfig {
     //    } else {
     //      false
     //    }
+    #[serde(default = "default_hmac_signature_enabled")]
     pub enabled: BooleanOrExpression,
 
     // The secret key used for HMAC signing and verification.
@@ -55,3 +56,7 @@ impl HMACSignatureConfig {
         }
     }
 }
+
+fn default_hmac_signature_enabled() -> BooleanOrExpression {
+    BooleanOrExpression::Boolean(false)
+}