Skip to content

Conversation

IvanGoncharov
Copy link
Member

No description provided.

@Copilot Copilot AI review requested due to automatic review settings June 16, 2025 19:48
Copy link

github-actions bot commented Jun 16, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copilot

This comment was marked as outdated.

@IvanGoncharov IvanGoncharov force-pushed the pr_branch4 branch 2 times, most recently from ce28714 to 0052198 Compare June 17, 2025 22:59
@IvanGoncharov IvanGoncharov requested a review from Copilot June 17, 2025 22:59
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a Hadolint step to the CI pipeline and refactors how the WebAssembly worker is built by replacing the old worker/bundle.js with a TypeScript-based bundler script.

  • Add a Dockerfile linting step using Hadolint in CI.
  • Remove legacy worker/bundle.js and introduce scripts/bundle_worker.ts for worker bundling.
  • Update worker Dockerfile and example Dockerfiles for improved SHELL settings, WORKDIR/CMD conventions, and bump Node versions.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
worker/bundle.js Removed legacy JavaScript bundling file.
worker/Dockerfile Added pipefail shell, adjusted WORKDIR paths, and switched CMD.
scripts/utils.ts Exported spawnOutput for use in bundling script.
scripts/bundle_worker.ts New TypeScript script to build and hash the worker via Docker.
package.json Updated "build:worker" to run the new TS bundler script.
example/webpack/Dockerfile Bumped base image to node:24, set absolute WORKDIR and JSON CMD.
example/express-server/Dockerfile Set absolute WORKDIR and JSON CMD.
docker-compose.yml Removed volume mount for worker-dist.
.github/workflows/ci.yml Added a Hadolint linting step for Dockerfiles.

@@ -6,25 +6,28 @@ ENV GRAPHVIZ_VERSION=8.0.1
ENV EXPAT_VERSION=2.5.0
ENV USE_CLOSURE=0

# Since bellow RUN commands use pipes set "pipefail"
Copy link
Preview

Copilot AI Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word 'bellow' is misspelled. It should be 'below'.

Suggested change
# Since bellow RUN commands use pipes set "pipefail"
# Since below RUN commands use pipes set "pipefail"

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant