-
-
Notifications
You must be signed in to change notification settings - Fork 530
ci: Add Hadolint step to lint Dockerfiles #460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
ce28714
to
0052198
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a Hadolint step to the CI pipeline and refactors how the WebAssembly worker is built by replacing the old worker/bundle.js
with a TypeScript-based bundler script.
- Add a Dockerfile linting step using Hadolint in CI.
- Remove legacy
worker/bundle.js
and introducescripts/bundle_worker.ts
for worker bundling. - Update worker Dockerfile and example Dockerfiles for improved SHELL settings, WORKDIR/CMD conventions, and bump Node versions.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
worker/bundle.js | Removed legacy JavaScript bundling file. |
worker/Dockerfile | Added pipefail shell, adjusted WORKDIR paths, and switched CMD. |
scripts/utils.ts | Exported spawnOutput for use in bundling script. |
scripts/bundle_worker.ts | New TypeScript script to build and hash the worker via Docker. |
package.json | Updated "build:worker" to run the new TS bundler script. |
example/webpack/Dockerfile | Bumped base image to node:24, set absolute WORKDIR and JSON CMD. |
example/express-server/Dockerfile | Set absolute WORKDIR and JSON CMD. |
docker-compose.yml | Removed volume mount for worker-dist . |
.github/workflows/ci.yml | Added a Hadolint linting step for Dockerfiles. |
@@ -6,25 +6,28 @@ ENV GRAPHVIZ_VERSION=8.0.1 | |||
ENV EXPAT_VERSION=2.5.0 | |||
ENV USE_CLOSURE=0 | |||
|
|||
# Since bellow RUN commands use pipes set "pipefail" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word 'bellow' is misspelled. It should be 'below'.
# Since bellow RUN commands use pipes set "pipefail" | |
# Since below RUN commands use pipes set "pipefail" |
Copilot uses AI. Check for mistakes.
0052198
to
76a33ee
Compare
No description provided.