Skip to content

Conversation

kasbaker
Copy link
Contributor

@kasbaker kasbaker commented Sep 4, 2025

This PR adds shortcuts for the remaining overloads for DSLSchema.__call__, including

  • "__typename", "__schema", "__type"DSLMetaField
  • "..."DSLInlineFragment
  • "fragment"DSLFragment (requires name to be a string)

Copy link

codecov bot commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (7fb869a) to head (27a4787).
⚠️ Report is 38 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master      #566    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           38        40     +2     
  Lines         2908      3235   +327     
==========================================
+ Hits          2908      3235   +327     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kasbaker kasbaker force-pushed the feature_dsl_schema_shortcuts branch from a6d12c7 to 54d7809 Compare September 4, 2025 05:56
@leszekhanusz
Copy link
Collaborator

leszekhanusz commented Sep 4, 2025

Thanks, but please remove the "fragment" shortcut.

After sleeping on it I don't see the point.

Like I said it's not really a shortcut to use ds("fragment", "name") instead of DSLFragment("name") and the additional argument of __call__ is awkward.

@leszekhanusz leszekhanusz merged commit 49de084 into graphql-python:master Sep 5, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants