Merge pull request #34 from graphql-python/test-should-more-mutate

Test should more mutate

Author: abawchen

graphene_mongo/tests/fixtures.py renamed to graphene_mongo/tests/setup.py

@@ -1,10 +1,12 @@
+import pytest
 from .models import (
     Article, Editor, EmbeddedArticle, Player,
     Reporter, Child, ProfessorMetadata, ProfessorVector,
 )
 
 
-def setup_fixtures():
+@pytest.fixture(scope='module')
+def fixtures():
     Editor.drop_collection()
     editor1 = Editor(
         id='1',

graphene_mongo/tests/test_mutation.py

@@ -0,0 +1,107 @@
+import graphene
+
+from graphene.relay import Node
+
+from .setup import fixtures
+from .models import (Article, Editor)
+from .types import (ArticleNode, EditorNode)
+
+
+def test_should_create(fixtures):
+
+    class CreateArticle(graphene.Mutation):
+
+        class Arguments:
+
+            headline = graphene.String()
+
+        article = graphene.Field(ArticleNode)
+
+        def mutate(self, info, headline):
+            article = Article(
+                headline=headline
+            )
+            article.save()
+
+            return CreateArticle(article=article)
+
+    class Query(graphene.ObjectType):
+
+        node = Node.Field()
+
+    class Mutation(graphene.ObjectType):
+
+        create_article = CreateArticle.Field()
+
+    query = '''
+        mutation ArticleCreator {
+            createArticle(
+                headline: "My Article"
+            ) {
+                article {
+                    headline
+                }
+            }
+        }
+    '''
+    expected = {
+        'createArticle': {
+            'article': {
+                'headline': 'My Article'
+            }
+        }
+    }
+    schema = graphene.Schema(query=Query, mutation=Mutation)
+    result = schema.execute(query)
+    assert not result.errors
+    assert result.data == expected
+
+
+def test_should_update(fixtures):
+
+    class UpdateEditor(graphene.Mutation):
+
+        class Arguments:
+            id = graphene.ID()
+            first_name = graphene.String()
+
+        editor = graphene.Field(EditorNode)
+
+        def mutate(self, info, id, first_name):
+            editor = Editor.objects.get(id=id)
+            editor.first_name = first_name
+            editor.save()
+            return UpdateEditor(editor=editor)
+
+    class Query(graphene.ObjectType):
+
+        node = Node.Field()
+
+    class Mutation(graphene.ObjectType):
+
+        update_editor = UpdateEditor.Field()
+
+    query = '''
+        mutation EditorUpdater {
+            updateEditor(
+                id: "1"
+                firstName: "Tony"
+            ) {
+                editor {
+                    firstName
+                }
+            }
+        }
+    '''
+    expected = {
+        'updateEditor': {
+            'editor': {
+                'firstName': 'Tony'
+            }
+        }
+    }
+    schema = graphene.Schema(query=Query, mutation=Mutation)
+    result = schema.execute(query)
+    # print(result.data)
+    assert not result.errors
+    assert result.data == expected

graphene_mongo/tests/test_query.py

@@ -2,18 +2,16 @@
 
 import graphene
 
-from .fixtures import setup_fixtures
+from .setup import fixtures
 from .models import (
     Editor, Player, Reporter, ProfessorVector
 )
 from .types import (
     EditorType, PlayerType, ReporterType, ProfessorVectorType
 )
 
-setup_fixtures()
 
-
-def test_should_query_editor():
+def test_should_query_editor(fixtures):
 
     class Query(graphene.ObjectType):
 
@@ -65,7 +63,7 @@ def resolve_editors(self, *args, **kwargs):
     assert all(item in result.data['editors'] for item in expected['editors'])
 
 
-def test_should_query_reporter():
+def test_should_query_reporter(fixtures):
 
     class Query(graphene.ObjectType):
         reporter = graphene.Field(ReporterType)
@@ -127,7 +125,7 @@ def resolve_reporter(self, *args, **kwargs):
     assert dict(result.data['reporter']) == expected['reporter']
 
 
-def test_should_custom_kwargs():
+def test_should_custom_kwargs(fixtures):
 
     class Query(graphene.ObjectType):
 
@@ -165,7 +163,7 @@ def resolve_editors(self, *args, **kwargs):
     assert all(item in result.data['editors'] for item in expected['editors'])
 
 
-def test_should_self_reference():
+def test_should_self_reference(fixtures):
 
     class Query(graphene.ObjectType):
 
@@ -229,7 +227,7 @@ def resolve_all_players(self, *args, **kwargs):
     assert json.dumps(result.data, sort_keys=True) == json.dumps(expected, sort_keys=True)
 
 
-def test_should_query_with_embedded_document():
+def test_should_query_with_embedded_document(fixtures):
 
     class Query(graphene.ObjectType):
         professor_vector = graphene.Field(ProfessorVectorType, id=graphene.String())

graphene_mongo/tests/test_relay_query.py

@@ -4,7 +4,7 @@
 
 from graphene.relay import Node
 
-from .fixtures import setup_fixtures
+from .setup import fixtures
 from .models import Article, Reporter
 from .types import (ArticleNode,
                     EditorNode,
@@ -13,14 +13,12 @@
                     ChildNode,)
 from ..fields import MongoengineConnectionField
 
-setup_fixtures()
-
 
 def get_nodes(data, key):
     return map(lambda edge: edge['node'], data[key]['edges'])
 
 
-def test_should_query_reporter():
+def test_should_query_reporter(fixtures):
 
     class Query(graphene.ObjectType):
         node = Node.Field()
@@ -115,7 +113,7 @@ def resolve_reporter(self, *args, **kwargs):
     assert dict(result.data['reporter']) == expected['reporter']
 
 
-def test_should_query_all_editors():
+def test_should_query_all_editors(fixtures):
 
     class Query(graphene.ObjectType):
         node = Node.Field()
@@ -168,7 +166,7 @@ class Query(graphene.ObjectType):
     assert dict(result.data['allEditors']) == expected['allEditors']
 
 
-def test_should_filter_editors_by_id():
+def test_should_filter_editors_by_id(fixtures):
 
     class Query(graphene.ObjectType):
         node = Node.Field()
@@ -207,55 +205,7 @@ class Query(graphene.ObjectType):
     assert dict(result.data['allEditors']) == expected['allEditors']
 
 
-def test_should_mutate():
-
-    class CreateArticle(graphene.Mutation):
-
-        class Arguments:
-            headline = graphene.String()
-
-        article = graphene.Field(ArticleNode)
-
-        def mutate(self, info, headline):
-            article = Article(
-                headline=headline
-            )
-            article.save()
-
-            return CreateArticle(article=article)
-
-    class Query(graphene.ObjectType):
-        node = Node.Field()
-
-    class Mutation(graphene.ObjectType):
-
-        create_article = CreateArticle.Field()
-
-    query = '''
-        mutation ArticleCreator {
-            createArticle(
-                headline: "My Article"
-            ) {
-                article {
-                    headline
-                }
-            }
-        }
-    '''
-    expected = {
-        'createArticle': {
-            'article': {
-                'headline': 'My Article'
-            }
-        }
-    }
-    schema = graphene.Schema(query=Query, mutation=Mutation)
-    result = schema.execute(query)
-    assert not result.errors
-    assert result.data == expected
-
-
-def test_should_filter():
+def test_should_filter(fixtures):
 
     class Query(graphene.ObjectType):
         node = Node.Field()
@@ -295,7 +245,7 @@ class Query(graphene.ObjectType):
     assert result.data == expected
 
 
-def test_should_filter_by_reference_field():
+def test_should_filter_by_reference_field(fixtures):
 
     class Query(graphene.ObjectType):
         node = Node.Field()
@@ -335,7 +285,7 @@ class Query(graphene.ObjectType):
     assert result.data == expected
 
 
-def test_should_filter_through_inheritance():
+def test_should_filter_through_inheritance(fixtures):
 
     class Query(graphene.ObjectType):
         node = Node.Field()
@@ -372,7 +322,7 @@ class Query(graphene.ObjectType):
         expected, sort_keys=True)
 
 
-def test_should_get_node_by_id():
+def test_should_get_node_by_id(fixtures):
     # Notes: https://goo.gl/hMNRgs
     class Query(graphene.ObjectType):
         reporter = Node.Field(ReporterNode)
@@ -398,7 +348,7 @@ class Query(graphene.ObjectType):
     assert result.data == expected
 
 
-def test_should_first_n():
+def test_should_first_n(fixtures):
 
     class Query(graphene.ObjectType):
 
@@ -454,7 +404,7 @@ class Query(graphene.ObjectType):
                for item in get_nodes(expected, 'editors'))
 
 
-def test_should_after():
+def test_should_after(fixtures):
     class Query(graphene.ObjectType):
 
         players = MongoengineConnectionField(PlayerNode)
@@ -497,7 +447,7 @@ class Query(graphene.ObjectType):
         expected, sort_keys=True)
 
 
-def test_should_before():
+def test_should_before(fixtures):
     class Query(graphene.ObjectType):
 
         players = MongoengineConnectionField(PlayerNode)
@@ -540,7 +490,7 @@ class Query(graphene.ObjectType):
         expected, sort_keys=True)
 
 
-def test_should_last_n():
+def test_should_last_n(fixtures):
     class Query(graphene.ObjectType):
         players = MongoengineConnectionField(PlayerNode)
 
@@ -582,7 +532,7 @@ class Query(graphene.ObjectType):
         expected, sort_keys=True)
 
 
-def test_should_self_reference():
+def test_should_self_reference(fixtures):
 
     class Query(graphene.ObjectType):
 
@@ -681,8 +631,3 @@ class Query(graphene.ObjectType):
     assert not result.errors
     assert json.dumps(result.data, sort_keys=True) == json.dumps(
         expected, sort_keys=True)
-
-
-# TODO:
-def test_should_paging():
-    pass

requirements.txt

@@ -1,5 +1,6 @@
 coveralls==1.2.0
 flake8==3.5.0
+flake8-per-file-ignores==0.6
 graphene==2.0.1
 iso8601==0.1.12
 mongoengine==0.15.0

setup.cfg

@@ -4,7 +4,10 @@ description-file = README.md
 [flake8]
 exclude = setup.py,docs/*,examples/*
 max-line-length = 130
-
+per-file-ignores =
+    graphene_mongo/tests/test_mutation.py: F401, F811
+    graphene_mongo/tests/test_query.py: F401, F811
+    graphene_mongo/tests/test_relay_query.py: F401, F811
 [coverage:run]
 omit = */tests/*