Remove transitive dependency on mio
#1283
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the transitive dependency on
mio
. This allows projects targetingwasm32-unknown-unknown
to compile. Fixes #1282.The
mio
dependency is being brought in via:juniper_axum
→axum
→axum/tokio
→tokio/net
→mio
. By disabling the default features ofaxum
, we disable itstokio
feature.axum
's comment onmio
:Reproduction Steps
rustup target add wasm32-unknown-unknown
cargo install cargo-generate && cargo generate --git https://github.com/rustwasm/wasm-pack-template
cargo add [email protected] --no-default-features
cargo add [email protected]
cargo build --target wasm32-unknown-unknown
cargo tree --target wasm32-unknown-unknown --invert mio
(no matches is what we want)cargo add [email protected]
cargo build --target wasm32-unknown-unknown
cargo tree --target wasm32-unknown-unknown --invert mio
Build log & errors