Skip to content

Fix content-header parsing in juniper_axum #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 26, 2024
Merged

Fix content-header parsing in juniper_axum #1289

merged 2 commits into from
Oct 26, 2024

Conversation

jgrund
Copy link
Contributor

@jgrund jgrund commented Oct 24, 2024

Check media type using starts_with instead of full string matching.

Fixes #1288

Fix content-header parsing in juniper_axum
32c7108 
Check media type using `starts_with` instead of full string matching.

Fixes graphql-rust#1288

Signed-off-by: Joe Grund <[email protected]>
LegNeato
LegNeato requested changes Oct 25, 2024
View reviewed changes
Copy link
Member

@LegNeato LegNeato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the great report and the PR! 🍻

Two quick things:

  1. Can you add an entry to the CHANGELOG?
  2. Can you add a test so we don't regress this in the future? (if it is too hard / will take too much time, please feel free to comment as such!)

@jgrund jgrund requested a review from LegNeato October 25, 2024 15:03
@jgrund
Copy link
Contributor Author

jgrund commented Oct 25, 2024

Thank you for the great report and the PR! 🍻

Two quick things:

  1. Can you add an entry to the CHANGELOG?
  2. Can you add a test so we don't regress this in the future? (if it is too hard / will take too much time, please feel free to comment as such!)

Done

@jgrund jgrund force-pushed the jgrund/fix-content-type-axum branch from 8c16b30 to b83ce7d Compare October 25, 2024 15:05
LegNeato
LegNeato approved these changes Oct 26, 2024
View reviewed changes
Copy link
Member

@LegNeato LegNeato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@LegNeato LegNeato merged commit 3c1a561 into graphql-rust:master Oct 26, 2024
179 of 180 checks passed
@jgrund
Copy link
Contributor Author

jgrund commented Oct 26, 2024

Thank you, can we cut a new release of juniper_axum with this fix?

@tyranron tyranron added enhancement Improvement of existing features or bugfix k::integration Related to integration with third-party libraries or systems lib::axum Related to `axum` crate integration labels Oct 28, 2024
@tyranron tyranron added this to the 0.17.0 milestone Oct 28, 2024
tyranron pushed a commit that referenced this pull request Oct 28, 2024
@jgrund @tyranron
Fix Content-Type header parsing in juniper_axum (#1289, #1288)
eb1fac2 
Signed-off-by: Joe Grund <[email protected]>
tyranron pushed a commit that referenced this pull request Oct 28, 2024
@jgrund @tyranron
Backport fix of Content-Type header parsing in juniper_axum (#1289,
bb529cc 
#1288)

Signed-off-by: Joe Grund <[email protected]>
@tyranron
Copy link
Member

@jgrund thank you for the PR!

Backported and released as 0.1.1: https://crates.io/crates/juniper_axum/0.1.1

@jgrund jgrund deleted the jgrund/fix-content-type-axum branch December 27, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LegNeato LegNeato LegNeato approved these changes

Assignees

@jgrund jgrund

Labels

enhancement Improvement of existing features or bugfix k::integration Related to integration with third-party libraries or systems lib::axum Related to `axum` crate integration

Projects

None yet

Milestone

0.17.0

Development

Successfully merging this pull request may close these issues.

juniper_axum breaks on valid Content-Type Header

3 participants

@jgrund @tyranron @LegNeato