Skip to content

fix cache & validation, re-run diagnostics for all files on file save #3489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix cache & validation, re-run diagnostics for all files on file save #3489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .changeset/rotten-buckets-promise.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
'graphql-language-service-server': minor
'graphql-language-service-cli': patch
'vscode-graphql': patch
---

**Fix:** Disable `getSchema()` results cacheing in the LSP server for now. Schema changes from file and/or network schema should be reflected in other files after they are saved or edit.

If this leads to excessive introspection schema fetching for URL `schema` configs, we will add an lru schema cache with configurable invalidation timeout. Hopefully `cache-control` headers take care of this problem transparently.



3 changes: 2 additions & 1 deletion packages/graphql-language-service-server/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,15 @@
"@vue/compiler-sfc": "^3.2.41",
"dotenv": "8.2.0",
"fast-glob": "^3.2.7",
"glob": "^7.2.0",
"glob": "^10.2.3",
"graphql-config": "4.3.0",
"graphql-language-service": "^5.1.5",
"mkdirp": "^1.0.4",
"node-abort-controller": "^3.0.1",
"nullthrows": "^1.0.0",
"vscode-jsonrpc": "^8.0.1",
"vscode-languageserver": "^8.0.1",
"vscode-languageserver-textdocument": "1.0.8",
"vscode-languageserver-types": "^3.17.2",
"vscode-uri": "^3.0.2"
},
Expand Down
Loading