Skip to content

Conversation

acao
Copy link
Member

@acao acao commented Sep 8, 2024

Resolves #3678

Requires reverting #3682

Copy link

changeset-bot bot commented Sep 8, 2024

⚠️ No Changeset found

Latest commit: b65cda9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.40%. Comparing base (484a9ad) to head (b65cda9).
Report is 135 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3769      +/-   ##
==========================================
+ Coverage   65.32%   65.40%   +0.07%     
==========================================
  Files         122      122              
  Lines        7003     7019      +16     
  Branches     2260     2247      -13     
==========================================
+ Hits         4575     4591      +16     
  Misses       2411     2411              
  Partials       17       17              
Files with missing lines Coverage Δ
packages/graphiql-react/src/schema.tsx 82.69% <ø> (ø)
packages/graphiql/test/schema.js 42.66% <100.00%> (+4.09%) ⬆️
...ervice/src/interface/getAutocompleteSuggestions.ts 86.12% <100.00%> (+0.29%) ⬆️
...graphql-language-service/src/parser/getTypeInfo.ts 83.78% <100.00%> (+0.33%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ruudk
Copy link

ruudk commented Jul 9, 2025

Thanks for working on this. Since the last push was 10 months ago, would it make sense to rebase this against latest changes? Also, the RFC is accepted, see comment

Copy link
Contributor

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny, human-facing typo fix


// TODO: decide if we want this. Discussing with @benjie, we might want to actually give the user flexibility here,
// instead of being strict
it('provides no more field suggestions once a oneOf field is chose and a user begins typing another field', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
it('provides no more field suggestions once a oneOf field is chose and a user begins typing another field', () => {
it('provides no more field suggestions once a oneOf field is chosen and a user begins typing another field', () => {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[graphiql] Allow passing header options to legacy WS client
3 participants