-
Notifications
You must be signed in to change notification settings - Fork 1.8k
language support for @oneOf
#3769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3769 +/- ##
==========================================
+ Coverage 65.32% 65.40% +0.07%
==========================================
Files 122 122
Lines 7003 7019 +16
Branches 2260 2247 -13
==========================================
+ Hits 4575 4591 +16
Misses 2411 2411
Partials 17 17
🚀 New features to boost your workflow:
|
Thanks for working on this. Since the last push was 10 months ago, would it make sense to rebase this against latest changes? Also, the RFC is accepted, see comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny, human-facing typo fix
|
||
// TODO: decide if we want this. Discussing with @benjie, we might want to actually give the user flexibility here, | ||
// instead of being strict | ||
it('provides no more field suggestions once a oneOf field is chose and a user begins typing another field', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it('provides no more field suggestions once a oneOf field is chose and a user begins typing another field', () => { | |
it('provides no more field suggestions once a oneOf field is chosen and a user begins typing another field', () => { |
Resolves #3678
Requires reverting #3682
devDependecies
to use[email protected]
for full@oneOf
supportgraphiql
because of upgrade to graphql v17 including support for new incremental delivery format #3682