cancel execution despite hanging async resolvers #4267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
yaacovCR
force-pushed
the
cancel-with-pending-resolver
branch
from
7dea80e to
99edfea
Compare
This was referenced Oct 29, 2024
yaacovCR
force-pushed
the
cancel-with-pending-resolver
branch
from
99edfea to
3404ffb
Compare
yaacovCR
force-pushed
the
cancel-with-pending-resolver
branch
from
3404ffb to
8bdda03
Compare
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yaacovCR
force-pushed
the
cancel-with-pending-resolver
branch
from
8bdda03 to
3cf7d57
Compare
yaacovCR
changed the title
JoviDeCroock
approved these changes
Oct 30, 2024
yaacovCR
added a commit
that referenced
this pull request
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this pull request, cancellation works by checking the abort signal status during execution, and throwing the reason if the abort signal has been triggered. This fails if an asynchronous resolver hangs.
This pull request changes the cancellation method to wrap promises returned by resolvers so that they immediately reject on cancellation.