Skip to content

Conversation

@yaacovCR
Copy link
Contributor

@yaacovCR yaacovCR commented Oct 28, 2024

depends on #4267

addresses: #3792

@netlify
Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 46643cd
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/6723755ac0a0780008becf9a
😎 Deploy Preview https://deploy-preview-4263--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR yaacovCR changed the title stop resolvers after execution ends WIP: stop resolvers after execution ends Oct 28, 2024
@yaacovCR yaacovCR added the PR: feature 🚀 requires increase of "minor" version number label Oct 28, 2024
@yaacovCR yaacovCR changed the title WIP: stop resolvers after execution ends stop resolvers after execution ends Oct 29, 2024
@yaacovCR yaacovCR force-pushed the cancel-execution-with-null-bubbling branch from 1387e36 to 3455728 Compare October 29, 2024 13:31
@yaacovCR yaacovCR changed the base branch from main to cancel-with-pending-resolver October 29, 2024 13:32
@yaacovCR yaacovCR marked this pull request as ready for review October 29, 2024 13:33
@yaacovCR yaacovCR requested a review from a team as a code owner October 29, 2024 13:33
@yaacovCR yaacovCR force-pushed the cancel-execution-with-null-bubbling branch from 3455728 to 75624cf Compare October 29, 2024 13:51
@yaacovCR yaacovCR marked this pull request as draft October 29, 2024 14:10
@yaacovCR yaacovCR force-pushed the cancel-execution-with-null-bubbling branch from 75624cf to 5601f69 Compare October 29, 2024 18:19
@yaacovCR yaacovCR force-pushed the cancel-with-pending-resolver branch from 7dea80e to 99edfea Compare October 29, 2024 19:13
@yaacovCR yaacovCR force-pushed the cancel-execution-with-null-bubbling branch from 5601f69 to 57552ab Compare October 29, 2024 19:20
@yaacovCR yaacovCR force-pushed the cancel-with-pending-resolver branch 2 times, most recently from 3404ffb to 8bdda03 Compare October 30, 2024 12:41
@yaacovCR yaacovCR force-pushed the cancel-execution-with-null-bubbling branch 2 times, most recently from c43b695 to 6bdb8b8 Compare October 30, 2024 13:02
@yaacovCR yaacovCR force-pushed the cancel-with-pending-resolver branch from 8bdda03 to 3cf7d57 Compare October 30, 2024 13:14
@yaacovCR yaacovCR force-pushed the cancel-execution-with-null-bubbling branch 2 times, most recently from c4226b8 to 3ab05ef Compare October 30, 2024 13:34
@yaacovCR yaacovCR marked this pull request as ready for review October 30, 2024 13:47
@yaacovCR yaacovCR requested a review from JoviDeCroock October 30, 2024 13:52
Base automatically changed from cancel-with-pending-resolver to main October 31, 2024 12:13
@yaacovCR yaacovCR force-pushed the cancel-execution-with-null-bubbling branch from 3ab05ef to 46643cd Compare October 31, 2024 12:17
@yaacovCR yaacovCR merged commit 670c26c into main Nov 1, 2024
35 checks passed
@yaacovCR yaacovCR deleted the cancel-execution-with-null-bubbling branch November 1, 2024 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: feature 🚀 requires increase of "minor" version number

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants