Skip to content

benchmark: increase process priority #3633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

benchmark: increase process priority #3633

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3a13f8
benchmark: increase process priority
yaacovCR Jun 7, 2022
fb36913
try manually passing along the uid
yaacovCR Jun 8, 2022
e7fc7dd
try inner sudo
yaacovCR Jun 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions resources/benchmark.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,9 +381,12 @@ function sampleModule(modulePath: string): BenchmarkSample {

const sampleCode = `
import fs from 'node:fs';
import os from 'node:os';

import { benchmark } from '${moduleURL}';

os.setPriority(os.constants.priority.PRIORITY_HIGHEST);

// warm up, it looks like 7 is a magic number to reliably trigger JIT
benchmark.measure();
benchmark.measure();
Expand Down Expand Up @@ -414,8 +417,10 @@ function sampleModule(modulePath: string): BenchmarkSample {
`;

const result = cp.spawnSync(
process.execPath,
'sudo',
[
'--close-from=4',
`"${process.execPath}"`,
// V8 flags
'--predictable',
'--no-concurrent-sweeping',
Expand All @@ -427,9 +432,10 @@ function sampleModule(modulePath: string): BenchmarkSample {
// Node.js flags
'--input-type=module',
'--eval',
sampleCode,
`"${sampleCode}"`,
],
{
shell: true,
stdio: ['inherit', 'inherit', 'inherit', 'pipe'],
env: { NODE_ENV: 'production' },
},
Expand Down